Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top N CPU intensive processes to CPU Menu Meter #76

Closed

Conversation

@HofiOne
Copy link
Contributor

@HofiOne HofiOne commented Apr 18, 2018

Initial version that's ready for Pull Request

New features:

  • Added option to display top N most CPU intensive processes in CPU Menu Meter
  • Pref pane option to set N
@HofiOne HofiOne changed the title Initial version that's ready for Pull Request Add top N CPU intensive processes to CPU Menu Meter Apr 18, 2018
@yujitach
Copy link
Owner

@yujitach yujitach commented Apr 26, 2018

Thanks, but could you update the preference panes for other languages too?

@HofiOne
Copy link
Contributor Author

@HofiOne HofiOne commented May 2, 2018

Unfortunately my Japanese, French, etc. knowledge is equal to zero ;)
Or do you mean adding the placeholders? Or using translators like Google Translate?

@HofiOne
Copy link
Contributor Author

@HofiOne HofiOne commented May 2, 2018

ohhh, I see, the prefpane resources! ok, adding them...

@yujitach
Copy link
Owner

@yujitach yujitach commented Jul 23, 2018

(I hesitated to merge yours since I wasn't very comfortable that your code runs "top" behind the scenes. I understand that that's inevitable, because there's no other way to get process infos from a non-system app...) Then I merged a pull request from another person. I'm very sorry that it conflicts with your changes of .nib files. We definitely need to move on to a more modern way of managing localized nib files.

@yujitach
Copy link
Owner

@yujitach yujitach commented Jul 23, 2018

I now changed the .nib localization to the modern method. Could you just modify the main .xib file? Then the change should be reflected in other languages automatically without translation; there shouldn't be any need to directly modify the files for each language.

Also, you don't have to and please do not include precompiled binary.

@HofiOne
Copy link
Contributor Author

@HofiOne HofiOne commented Aug 23, 2018

will create a new branch for this and a new PR

@HofiOne HofiOne closed this Aug 23, 2018
@HofiOne HofiOne deleted the HofiOne:Add-Top-CPU-Intense-Processes-menu- branch Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.