feat: flip video horizontally#4437
Merged
yuliskov merged 1 commit intoyuliskov:masterfrom Mar 23, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed a way to horizontally flip videos, and noticed it wasn't implemented so this is my attempt at it.
This addresses issues #319 and #2902.
The implementation is mostly based on the rotate feature code, using
setScaleX(-1)on the player view to flip horizontally.I've tested it on an emulator (Android TV API 31) and on a Chromecast with Google TV, seems to work properly and no regressions were observed.
Attached a screencast demoing the change.
Let me know if there's something to improve or modify. Thank you!
Demo
flip_video_smarttube.mp4