Be compatible with python 2 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengsrc
reviewed
Jan 20, 2017
| @@ -21,4 +21,5 @@ | |||
| 'PyYAML >= 3.1', | |||
| 'qingstor-sdk', | |||
| 'docutils >= 0.10', | |||
| 'tqdm', | |||
There was a problem hiding this comment.
Please specify a version of the 3rd-party package (tqdm and qingstor-sdk).
| print( | ||
| "Python2 on Windows do not support this key_name: %s", | ||
| key_name | ||
| ) |
There was a problem hiding this comment.
print(
"WARN: Python 2 on Windows does not support this object key: %s",
key_name
)
pengsrc
reviewed
Jan 20, 2017
| @@ -0,0 +1,5 @@ | |||
| qingstor-sdk | |||
| def step_impl(context): | ||
| command = qsctl( | ||
| "cp", | ||
| "tmp/{filename}".format(filename="中文测试"), |
There was a problem hiding this comment.
Test data and expected behavior should be stored in feature files, such as object keys, file size, success status and error code.
Signed-off-by: Xuanwo <xuanwo@yunify.com>
Signed-off-by: Xuanwo <xuanwo@yunify.com>
Signed-off-by: Xuanwo <xuanwo@yunify.com>
Signed-off-by: Xuanwo <xuanwo@yunify.com>
Signed-off-by: Xuanwo <xuanwo@yunify.com>
Signed-off-by: Xuanwo <xuanwo@yunify.com>
Signed-off-by: Xuanwo <xuanwo@yunify.com>
Xuanwo
force-pushed
the
compatible
branch
4 times, most recently
from
271f59e
to
75cce15
Compare
Signed-off-by: Xuanwo <xuanwo@yunify.com>
| ) | ||
| ) | ||
| command.wait() | ||
|
|
Signed-off-by: Xuanwo <xuanwo@yunify.com>
pengsrc
approved these changes
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.