Build fails against qt-5.9 and python 3.6

[khurshid-alam]

I am getting following error:

ubuntu-ui-toolkit-1.3.2190+17.04.20170327ubuntu1/tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_qquicklistview.py:179:9: E722 do not use bare except

ubuntu-ui-toolkit-1.3.2190+17.04.20170327ubuntu1/tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_uclistitem.py:52:9: E722 do not use bare except

It seems to be related with latest pycodestyle version 2.3.0 (2017-01-30) which was added the new E722 check: Add E722 warning for bare except clauses

The related launchpad bug is here:

https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1710926

[jsalatas]

Can we put it on hold for now? I'm currently working on porting in Qt 5.9 although I'm using ubuntu 16.04 (and not 17.10). I didn't had any issues with python but I have a set of patches for compiling it against Qt 5.9. I haven't finalized this yet, but I can publish it if you want.

[khurshid-alam]

Alright. I can wait. And yes you can publish those patches..I will test. Thanks.

[jsalatas]

see attached the debian directory containing all the required patches for Qt 5.9.

Notice that:

1. I have created and tested it in ubuntu 16.04 while backporting Qt 5.9.1 to it.
2. I haven't push it to git yet, as I'm still working on it.

debian.zip

[khurshid-alam]

Thanks. It seems there are some issues with gsettings-qt which needs to be compiled first against 5.9. I am trying that now.

[jsalatas]

That worked for me out-of-the-box. Which code are you using? If you use the 0.1+16.04.20160329-0yunit0+ubuntu+16.04 tag you should be fine

https://github.com/yunit-io/gsettings-qt/releases/tag/debian%2F0.1%2B16.04.20160329-0yunit0%2Bubuntu%2B16.04

[jsalatas]

Oh! BTW: I understand that you are currently working in 17.10 right? If that's the case I would appreciate if you could commit any additional patches you used. That would save us duplicated effort :)

[jsalatas]

Also, if you are trying to build the whole yunit stack in 17.10 (which I'm guessing you are trying to do) you would probably need some additional patches, namely for qtubuntu (ported already but haven't committed to github yet) and of course yunit which is somewhat tricky (I have it in a working state already but I still need to wok with some failing uitests).

In any case I guess I'll try in the next couple of days to commit anything that I have done so far. I'll keep you posted....

[khurshid-alam]

Thanks.

And yes, since I have decided to do it, let's do it properly. I have asked for subscription for devel mailing list.

[khurshid-alam]

@jsalatas Thanks for the patch. It compiles successfully. https://code.launchpad.net/~khurshid-alam/+recipe/ubuntu-ui-toolkit-daily

I dropped +16.04 as ppa already adds ~ubuntu-17.10. Instead I am using {debupstream}-0yunit0+{time}

For the time being I am compiling in experimental ppa. But I have also created Yunit ppa (but it would be better if you people do that as I talked in mailing list)...one qt-5.9 lands I will upload it Yunit ppa.

Do you have any idea what order other packages can be compiled? I believe ubuntu-settings-components comes first as lots of packages depend on it.

Online-accounts and accounts-plugins should also compile just fine.....but I could be wrong.

[jsalatas]

Do you have any idea what order other packages can be compiled? I believe ubuntu-settings-components comes first as lots of packages depend on it.

This is rather tricky, as there are some packages with circular dependencies that need bootstraping. I'm planning for a long time now to create a wiki page about it but neve had time to do so :(
Anyway, I'm attaching you some admittedly vague and cryptic notes regarding the build order of the packages which I'm not sure if you make any sense :\

In any case you will notice that some of these packages (like the ubuntu-system-settings) require two builds: one initial with reduced functionality (DEB_BUILD_PROFILES=stage1) and then after building all the other dependencies come back and have a normal full build of the package. Yunit's github repos contain all the required definitions in debian/control and debian/rules for this.

Please let me know if you have any issues. I'll reply to your mailing list message a little bit later today.

Thanks for your help and feedback!
notes.txt

[khurshid-alam]

Thanks for the notes...No it does make lots of sense to me. Thanks.

But I may have replied too soon for toolkit ....i am experiencing some issue....it is failing a unit test

1. I am using release branch from this repo which also has 0001-Disabled-failed-tests.patch which is not included in your debian zip.

2. So when I compiled without it , it gave me

make[5]: Entering directory '/<<BUILDDIR>>/ubuntu-ui-toolkit-1.3.2190+17.04.20170715/tests/unit/i18n/LocalizedApp' set -e; msgfmt /<<BUILDDIR>>/ubuntu-ui-toolkit-1.3.2190+17.04.20170715/tests/unit/i18n/LocalizedApp/po/en_US.po -o /<<BUILDDIR>>/ubuntu-ui-toolkit-1.3.2190+17.04.20170715/tests/unit/i18n/LocalizedApp/localizedApp/share/locale/en/LC_MESSAGES/localizedApp.mo; msgfmt: error while opening "/<<BUILDDIR>>/ubuntu-ui-toolkit-1.3.2190+17.04.20170715/tests/unit/i18n/LocalizedApp/localizedApp/share/locale/en/LC_MESSAGES/localizedApp.mo" for writing: No such file or directory Makefile:380: recipe for target 'mo' failed make[5]: *** [mo] Error 1

which is odd because qmake should take care of that

3. So I disabled the test (see khurshid-alam/ubuntu-ui-toolkit@9d80e73).....Now it skips it.....but now I have this 1 error:

[New Thread 0x7fffd347e700 (LWP 24363)] FAIL! : components::Scrollbar::test_actionSteppers(Content item with margins and vertical scrollbar) property running Actual (): false Expected (): true Loc: [/<<BUILDDIR>>/ubuntu-ui-toolkit-1.3.2190+17.04.20170715/tests/unit/visual/ScrollbarTestCase13.qml(180)]

/<<BUILDDIR>>/ubuntu-ui-toolkit-1.3.2190+17.04.20170715/tests/checkresults.sh /<<BUILDDIR>>/ubuntu-ui-toolkit-1.3.2190+17.04.20170715/tests/*.xml || exit 1;
1 failures which MUST be fixed:
  tst_scrollbar.13.qml

The following tests issued 166 expected warnings:
  components_benchmark
  inversemousearea
  performance
  qquick_image_extension
  recreateview
  swipearea
  touchregistry
  tst_label13.qml
  tst_optionselector.13.qml
  tst_picker.13.qml
  tst_scrollview.13.qml
  tst_tabbar.11.qml

Woot! Known problematic tests passed!
Consider removing these from EXCEPTIONS in tests/checkresults.sh!
  page
  tst_focus.13.qml
  tst_listitems_itemselector.11.qml
  tst_page.11.qml
  tst_picker.11.qml
  tst_tabs.11.qml
  tst_textinput_touch.SEGFAULT.11.qml

Same thing happens if I run locally

tests/xvfb.sh tests/unit/runtest.sh test/unit/visual/tst_scrollbar.13.qml

[jsalatas]

1. I am using release branch from this repo which also has 0001-Disabled-failed-tests.patch which is not included in your debian zip.

2. So when I compiled without it , it gave me
   .....

Which repo is this?

Regarding the "No such file or directory " this was my mistake: in my initial commit I didn't notice that there were some needed empty dirs (which git cannot handle) but I believe I fixed it when I noticed it.

[khurshid-alam]

Source: 064bb03
Patches-Applied: All patches from debian zip + a existing patch (0001-Disabled-failed-tests.patch)
Building Stack: Ubuntu artful 17.10 (qt-5.9, gcc-7, python 3.6)
PPA: https://code.launchpad.net/~khurshid-alam/+archive/ubuntu/yunit

Problemetic unit test: tst_scrollbar.13.qml
Complete build-log:
https://code.launchpad.net/~khurshid-alam/+archive/ubuntu/experimental-ppa/+build/13296974/+files/buildlog_ubuntu-artful-amd64.ubuntu-ui-toolkit_1.3.2190+17.04.20170715-0yunit0+201708251712~ubuntu17.10.1_BUILDING.txt.gz

(search for string 1 failed)

So for the time being I disabled unit test for tst_scrollbar.13.qml. Everything else is fine. :)

[jsalatas]

Source: 064bb03

You're right! I have fixed it in upstream branch but apparently it didn't make it to the debian package. My bad! Sorry :(
f4a7451

So for the time being I disabled unit test for tst_scrollbar.13.qml

I believe this is due to this bug which will be eventually fixed in Qt 5.9.2 and which cause many tests to be unstable (including the test in question)

https://bugreports.qt.io/browse/QTBUG-61741

In the backport to 16.04 in which I'm currently working applying this patch seems to solve this issues.

I guess if you run the test in question several times you will notice that sometimes it passes while other times it fails. So yeah, I guess it is better to ignore/disable it for knoe and wait for Qt 5.9.2 to be released. As a final note in the zip I sent you there is the 0008-Qt-5.9-fix-tst_scrollbar.13-test.patch which tries to fix it by adding a wait time wait(10) and which seems to work for me in both ubuntu 16.04 and debian unstable. May you could try raising the wait value from 10 to something bigger :\