Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail verification and password reset #208

Merged
merged 32 commits into from Dec 30, 2016
Merged

Mail verification and password reset #208

merged 32 commits into from Dec 30, 2016

Conversation

tiltec
Copy link
Member

@tiltec tiltec commented Oct 25, 2016

Integrate support for sending out mails and use it to verify e-mail addresses

Todo:

  • make test work (server config missing, no API key)
  • write unit & integration test
  • setup on fstool.yunity.org (local config file)
  • trigger mail verify after mail change
  • use email instead of id to request password reset
  • change passwords
  • check reverification after changing mail address
  • include frontend url into mail template for verification
  • think about translation support for mail
  • nice mail template
  • decide if it's worth using a serializer for password reset
  • check transaction status of mail
  • log password resets to influxdb
  • add transifex to project
  • decouple the frontend: use a parameter on the password_reset request for the email URL prefix
  • consider case: mail is not verified and password reset is triggered

Closes #92

@codecov-io
Copy link

codecov-io commented Dec 24, 2016

Current coverage is 96.34% (diff: 99.64%)

Merging #208 into master will increase coverage by 0.51%

@@             master       #208   diff @@
==========================================
  Files            68         70     +2   
  Lines          1631       1860   +229   
  Methods           0          0          
  Messages          0          0          
  Branches         67         76     +9   
==========================================
+ Hits           1563       1792   +229   
  Misses           54         54          
  Partials         14         14          

Powered by Codecov. Last update db2cf56...c2ca33f

Didn't pay attention during the merge and ended up with conflicting
package versions
Is the Django recommendation
Might be useful when users have multiple browsers.
This reverts commit ae8ee3b.

Ahm.. might not be the best idea to do. Let's play safe for now and
require login.
Also fixes the issue that the user doesn't see himself if he's not in a
group.
Closes #228.
Also move verify code from serializer to model class
Recommend console mail backend
A dummy is enough, we don't use this value very much right now.
@tiltec
Copy link
Member Author

tiltec commented Dec 25, 2016

I think this could be merged soon. I will file the remaining tasks as issues :)

@tiltec tiltec changed the title WIP: Mailing Mailing Dec 25, 2016
@tiltec tiltec changed the title Mailing Mail verification and password reset Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants