Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order feedback by activity start date #1044

Merged
merged 1 commit into from Aug 18, 2020

Conversation

nicksellen
Copy link
Member

Fixes https://github.com/yunity/karrot-frontend/issues/2157

The cursor pagination disallows double-underscore lookups for pagination ordering, I think because it assumes they will break the "rules" on what can be a valid ordering field, see docs. In our case I think this should be fine still, as by the time the feedback is created the pickup cannot be changed anyway as it's in the past. I cheated the check by using an annotation...

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #1044 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1044   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files         450      450           
  Lines       16836    16836           
  Branches     1136     1136           
=======================================
  Hits        15820    15820           
  Misses        819      819           
  Partials      197      197           
Impacted Files Coverage Δ
karrot/activities/api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b691309...39d8df9. Read the comment docs.

@nicksellen nicksellen requested a review from tiltec August 18, 2020 07:50
@tiltec
Copy link
Member

tiltec commented Aug 18, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants