New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep finished pickup dates in DB #344

Merged
merged 3 commits into from Aug 11, 2017

Conversation

Projects
None yet
2 participants
@tiltec
Copy link
Member

tiltec commented Aug 10, 2017

So that the planned Feedback model can reference them.

Closes #328

I thought about writing a data migration that recovers deleted pickup dates from history entries, but I don't see the use case. I think it's sufficient if giving feedback is only possible for pickups that happened after this PR is merged. Opinions?

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 10, 2017

Codecov Report

Merging #344 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   98.21%   98.22%   +<.01%     
==========================================
  Files         153      154       +1     
  Lines        4157     4165       +8     
  Branches      181      181              
==========================================
+ Hits         4083     4091       +8     
  Misses         54       54              
  Partials       20       20
Impacted Files Coverage Δ
...s/migrations/0016_pickupdate_done_and_processed.py 100% <100%> (ø)
...odsaving/management/commands/create_sample_data.py 100% <100%> (ø) ⬆️
foodsaving/history/tests/test_api.py 100% <100%> (ø) ⬆️
...gement/tests/test_process_finished_pickup_dates.py 100% <100%> (ø)
foodsaving/stores/models.py 96% <100%> (+0.12%) ⬆️
...nagement/commands/process_finished_pickup_dates.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f78056...c30c806. Read the comment docs.

@tiltec tiltec merged commit d3af562 into master Aug 11, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
ci/circleci-e2e end-to-end test suite
Details
codecov/patch 100% of diff hit (target 98.21%)
Details
codecov/project 98.22% (+<.01%) compared to 3f78056
Details

@tiltec tiltec deleted the persist-pickup-dates branch Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment