New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize vue components #1124

Open
tiltec opened this Issue Oct 31, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@tiltec
Copy link
Member

tiltec commented Oct 31, 2018

After #1066 we have everything nicely split up into modules, but our vue components are still a bit disorganized.

Main topics:

It's unclear from file path and name if a component connects to vuex or not (some have UI prefix, but not all)
-> To address this, we could borrow some concepts from Dan Abramov and add Container as suffix.

It's unclear if a component is reused or if it's just referenced in one file
-> For this, it seems clear that only non-container components would be reused, and only a few components are used more than two times. We could move the reusable components to a subdirectory named reusables.

Need to play a bit with it.

@tiltec tiltec self-assigned this Oct 31, 2018

@tiltec tiltec added the frontend label Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment