New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of changed pickup settings when saving series #797

Closed
brnsolikyl opened this Issue Dec 3, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@brnsolikyl
Copy link

brnsolikyl commented Dec 3, 2017

This is a possible bug, that I tried in different groups in dev and production. When I change the additional information field with a new text in a series of pickups and save it, the pickups that have already someone signed up to do not change. This is how you can test:

  • Create a series of pickups, add a text to additional information for the whole series
  • Join one of more pickups
  • Go back and edit the series of pickups and change the text in additional information, then save
  • Every pickup should be updated with the new text, except for those where a user joined

Updating the individual pickup worked for me.

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Jan 3, 2018

Ah, I get what you mean! That's intentional, after people joined the pickup it won't get updated by the series anymore.

Do you think we should change it? Or just document it better?

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Jan 3, 2018

Currently we have these actions on pickups:

  • modify comment
  • modify time
  • delete

If a series gets deleted, usually it will also affect the pickups, except in these cases:

  • when the pickup has a collector
  • when the attribute has been changed in the pickup itself (see #611 for a change request regarding to this, it's not resolved yet)
@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Jul 17, 2018

Possible next steps:

  • add a button to the pickup edit window: "reset to series default" (#611)

  • or: add a checkbox when saving series: "override changed pickup settings"

  • or: add a modal on saving series: "this series contains pickups with changed settings, do you want to override?"

  • add a list to series delete: "these pickups will not get deleted because people already joined them. please notify the collectors in the pickup chats about the cancellation."

@tiltec tiltec changed the title Changing and saving additional commentaries in a series of pickups (bug?) Improve handling of changed pickup settings when saving series Jul 17, 2018

@tiltec tiltec removed their assignment Jul 17, 2018

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Sep 12, 2018

This could be the source of confusion such as https://community.foodsaving.world/t/double-pickup-dates-bug-report/110/4

In this case, it might be about deleting a series, there will be some pickups dangling. Either we should inform users about this behavior, or change the behavior to something more expected.

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Nov 21, 2018

As other problems related to recurring pickups came up, I propose some bigger changes that might also affect this issue: https://community.foodsaving.world/t/how-to-better-handle-changes-to-recurring-pickups/174

@tiltec tiltec referenced this issue Dec 13, 2018

Merged

Improve handling of pickup series modifications v2 #1147

3 of 10 tasks complete

@tiltec tiltec closed this in #1147 Jan 1, 2019

tiltec added a commit that referenced this issue Jan 1, 2019

Improve handling of pickup series modifications v2 (#1147)
Closes #797

- show pickup_disabled, pickup_enabled and pickup_moved notifications
- allow to disable/enable pickups
- show which pickups differ from series defaults
- prevent date changes for pickups that are part of a series
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment