New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user photos to search results #865

Open
tiltec opened this Issue Feb 4, 2018 · 14 comments

Comments

Projects
None yet
5 participants
@tiltec
Copy link
Member

tiltec commented Feb 4, 2018

It would be nice to show user photos in the search results instead of the icon. Makes it easier to identify users.

image

Refs #817

@SiddharthaSarma

This comment has been minimized.

Copy link
Contributor

SiddharthaSarma commented Feb 7, 2018

Hi @tiltec
Can I work on it?

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Feb 7, 2018

Yes @SiddharthaSarma, please go ahead :)

@SiddharthaSarma

This comment has been minimized.

Copy link
Contributor

SiddharthaSarma commented Feb 8, 2018

Thanks @tiltec :)

Do you want me to show the default user icon if the user doesn't have any image, like the one below?

screenshot-2018-2-8 karrot

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Feb 8, 2018

I think users would expect to see the same thing in search as the ProfilePicture component shows. Makes it nice and uniform.

Therefore, I would add the user random art, the initials and not have the picture rounded.

@SiddharthaSarma

This comment has been minimized.

Copy link
Contributor

SiddharthaSarma commented Feb 9, 2018

Okay @tiltec
But when I went through the documentation of quasar autocomplete component.
I found there is no option to add the custom HTML.
As Random art gives the svg image, I found there is no way to link to autocomplete.
For reference please check the properties section of autocomplete
http://quasar-framework.org/components/autocomplete.html#Using-Static-Data

If you know any other ways of doing it, could you please tell me?

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Feb 9, 2018

Ah, that could be the reason why we didn't add it yet. Would it be hard to replace the autocomplete component with a custom setup, e.g. a input box as search and a popover with list items as result?

@SiddharthaSarma

This comment has been minimized.

Copy link
Contributor

SiddharthaSarma commented Feb 9, 2018

I will try it

@varsha6319

This comment has been minimized.

Copy link

varsha6319 commented Feb 27, 2018

Hey tiltec
Do you want to have the user photo in a square shape, Can I work towards it?

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Feb 27, 2018

Hi @varsha6319 yes please. I think this feature is much quicker to solve than #672.

It would be good it would use the existing ProfilePicture component, so that the look is unified.

@tiltec tiltec added the frontend label Feb 27, 2018

@harsha4444

This comment has been minimized.

Copy link

harsha4444 commented Mar 15, 2018

Hi @tiltec . Can i work on it

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Mar 15, 2018

Sure @harsha4444 !

@agatatalita

This comment has been minimized.

Copy link

agatatalita commented Aug 1, 2018

Hi @harsha4444 did you make any progress with this?

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Oct 31, 2018

I really want to have this myself, I use the search quite a lot :)

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Jan 1, 2019

Lowering the priority and removing my assignment, there are more pressing things to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment