New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to include pictures in pickup feedback #963

Open
djahnie opened this Issue Mar 13, 2018 · 11 comments

Comments

Projects
None yet
3 participants
@djahnie
Copy link
Member

djahnie commented Mar 13, 2018

Requested by LMR Fürth.

At the moment they are examining the possibilities Karrot offers and may switch to it around Easter. It's not dependent on this and not decided upon.

@djahnie djahnie added the feature label Mar 13, 2018

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Mar 13, 2018

Cool feature, I like it! Maybe just one picture in the beginning, to see how people adopt it?

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Oct 31, 2018

Could be tackled as a starter task! :)

@cstefanj

This comment has been minimized.

Copy link

cstefanj commented Jan 8, 2019

Hi! I'm looking for a starter task to tackle. What skills do I need to be able to contribute to this one?

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Jan 8, 2019

Hi @cstefanj, welcome! This task needs both frontend and backend changes, so Vue/JS and Django/Python skills would be helpful. (If you prefer to work only in Python or JavaScript land, you might be better off with another task)

@cstefanj

This comment has been minimized.

Copy link

cstefanj commented Jan 8, 2019

Hi! Ok, then I think I need to keep looking. I would be happy to look at the Python/Django part (although I have used Flask more) but have no clue when it comes to the frontend. Thanks for the quick reply!

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Jan 8, 2019

Yeah, I like Python more than JavaScript, but it's actually not too bad working with VueJS.

Anyhow, if you want to work on the backend bits, I could take over the frontend part. #891 might be a bit more needed than this issue and has good chunk of backend work as well, so maybe that's something you would like to have a try at?

Coming from Flask, the Django & Django REST Framework architecture might feel a bit heavy to you, so I'm happy to answer any questions about where to find parts of the code :)

@cstefanj

This comment has been minimized.

Copy link

cstefanj commented Jan 8, 2019

With that approach I would be happy to give the backend part of #891 a try. Looking at that thread it looks like several people have already given it a go, not sure if I'm perhaps getting in over my head here since this would be my first contribution (so, yes, I'm afraid I will need some hand-holding ...). Do you already have thoughts on the frontend part and what you would need from the backend?

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Jan 8, 2019

I added some information to the other issue.

About getting over your head: after setting up the backend locally, the hardest work should already be done ;)

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Jan 30, 2019

Coming back to this issue: it's already possible to reference a picture in pickup feedback because the text is rendered as Markdown, but users would need to figure out the hosting solution by themselves (needs to be on https to fulfill our Content Security Policy).
This is closely related to having pictures in any message on Karrot, so if we decide to implement that, we might add an option to upload pictures and add them into a Markdown field with a single click. Might look into Discourse how they do it.

@cstefanj

This comment has been minimized.

Copy link

cstefanj commented Feb 2, 2019

@tiltec Hi! Let me know if any backend work comes up on this that you think I could have a look at. :)

@tiltec tiltec removed the starter-task label Feb 3, 2019

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Feb 3, 2019

Sure! My last comment was of general nature, there's no need to implement it in near future.

For more backend tasks, I marked some as "help wanted" here: https://github.com/yunity/karrot-frontend/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3Abackend+label%3Ahelp-wanted
For example, #1038 might be straightforward :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment