New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pickup comment field #549

Merged
merged 3 commits into from Jul 4, 2017

Conversation

Projects
None yet
3 participants
@tiltec
Copy link
Member

tiltec commented Jul 3, 2017

Closes #158

image

@D0nPiano have a look at the radically reduced pickupListItem stylesheet. Hope I didn't destroy your design idea completely.. I find it easier to work with less style ;)

EDIT: there's now also an edit button for each pickup in store view

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Jul 3, 2017

image

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 3, 2017

Codecov Report

Merging #549 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
+ Coverage   98.62%   98.64%   +0.02%     
==========================================
  Files         231      231              
  Lines        3698     3699       +1     
==========================================
+ Hits         3647     3649       +2     
+ Misses         51       50       -1
Impacted Files Coverage Δ
...kupList/pickupListItem/pickupListItem.component.js 100% <ø> (ø) ⬆️
...s/group/_pickupEditCreate/pickupEditCreate.spec.js 100% <ø> (ø) ⬆️
...p/_pickupEditCreate/pickupEditCreate.controller.js 97.56% <ø> (ø) ⬆️
...pp/components/group/_pickupList/pickupList.spec.js 97.22% <100%> (+0.07%) ⬆️
...ponents/group/_pickupList/pickupList.controller.js 94.87% <100%> (+2.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d0412...9ce8460. Read the comment docs.

@tiltec

This comment has been minimized.

Copy link
Member

tiltec commented Jul 3, 2017

Design refinements welcome!

@D0nPiano

This comment has been minimized.

Copy link
Member

D0nPiano commented Jul 3, 2017

Changed the pickuplist item to a column-based flex layout - the button always stays on the right, the other stuff flows around the left side.

screenshot from 2017-07-04 00-08-25

@tiltec tiltec merged commit 9821658 into master Jul 4, 2017

5 of 6 checks passed

ci/circleci-e2e end-to-end test suite
Details
Node Security No known vulnerabilities found
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 98.62%)
Details
codecov/project 98.64% (+0.02%) compared to d1d0412
Details
security/snyk No new vulnerabilities
Details

@tiltec tiltec deleted the pickupComment branch Jul 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment