Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: One2one conversations #855

Closed
wants to merge 21 commits into from

Conversation

Projects
None yet
2 participants
@D0nPiano
Copy link
Contributor

commented Jan 22, 2018

First drafts of one-to-one conversations #832

Depends on #770 #848 and other backend related tasks

Desktop

#/chat

1to1conv1

chatFloater

1to1conv2

chat popover

1to1conv3

Mobile Layout

#/chat

1to1conv4

@tiltec

This comment has been minimized.

Copy link
Member

commented Jan 22, 2018

Nice! Makes me want to implement the remaining bits, but I want to finish some other stuff first.

@codecov

This comment has been minimized.

Copy link

commented Feb 4, 2018

Codecov Report

Merging #855 into master will decrease coverage by 0.36%.
The diff coverage is 46.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
- Coverage   65.11%   64.75%   -0.37%     
==========================================
  Files         156      159       +3     
  Lines        4125     4193      +68     
  Branches      836      856      +20     
==========================================
+ Hits         2686     2715      +29     
- Misses       1406     1445      +39     
  Partials       33       33
Impacted Files Coverage Δ
src/store/index.js 100% <ø> (ø) ⬆️
src/routes/main.js 100% <100%> (ø) ⬆️
src/components/Conversation/ChatList.vue 100% <100%> (ø)
src/components/Layout/KTopbarUI.vue 66% <100%> (+1.41%) ⬆️
...rc/components/Conversation/ConversationCompose.vue 65.62% <100%> (-5.81%) ⬇️
src/components/Conversation/ChatListUI.vue 57.69% <56%> (ø)
src/store/modules/chatFloaters.js 7.4% <7.4%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb29ae...e63dba8. Read the comment docs.

@tiltec

This comment has been minimized.

Copy link
Member

commented Jun 28, 2018

Now implemented in the same way as pickup conversations. Still needs a conversations overview page, but I think this PR can be closed already.

@tiltec tiltec closed this Jun 28, 2018

@tiltec tiltec deleted the one2oneConversations branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.