Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropzone is missing icon in version 5.3.1 & 5.3.2 #106

Closed
AceTutor opened this issue May 6, 2019 · 5 comments

Comments

@AceTutor
Copy link

commented May 6, 2019

Icon Missing in Dropzone
Sorry not to have noticed this earlier. Version 5.2.4 works fine but the changes made in vs 5.3.1 and vs 5.3.2 result in a box without the cloud upload icon.

Rather than wait for the next update can I ask that you provide a patch file/s once resolved.

Thanks for a great product.

@yuzoolcode

This comment has been minimized.

Copy link
Owner

commented May 6, 2019

Thanks - will need to test this

Can't imagine what it is without taking a testing look - could be something along the lines of the Font Awesome not loading correctly - the web inspector in the browser might give you a clue for now

@AceTutor

This comment has been minimized.

Copy link
Author

commented May 6, 2019

Thanks Michael for prompt response overnight.
Please check out my live test page at https://www.gcmfc.com.au/pulse-5.3.2/test-pulse
Here is a totally clean install of v5.3.2 - I've only changed the timezone & front-end editing otherwise everything is original. To test Dropzone I have added one extra image to gallery1.
Please test it for yourself.
I await your conclusions and hopefully an early resolution.
Cheers John

@yuzoolcode

This comment has been minimized.

Copy link
Owner

commented May 6, 2019

CleanShot 2019-05-07 at 07 05 45

The icon has changed in FA 5

The solution is to change the reference to the icon to class="fa fa-cloud-upload-alt fa-3x"

Add "-alt"
https://fontawesome.com/icons/cloud-upload-alt?style=solid

Change on line 142:
inc/plugins/drop/dropzone.js

@yuzoolcode

This comment has been minimized.

Copy link
Owner

commented May 6, 2019

  • this has been added to the codebase for next release
  • I'll close this but if your test doesn't work then please re-open
  • let me know!

@yuzoolcode yuzoolcode closed this May 6, 2019

@AceTutor

This comment has been minimized.

Copy link
Author

commented May 7, 2019

Thanks - solved beautifully. Appreciate rapid solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.