New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in WYSIWYG link to https in Redactor #17

Closed
yuzoolcode opened this Issue Feb 5, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@yuzoolcode
Owner

yuzoolcode commented Feb 5, 2018

hi guys,

when i try to enter a HTTPS link the WYSIWYG removes the "s" after saving the block.

workaround: enter the s manually in HTML-Code View.

using pulse 5.0.1

It's a bug in Redactor 2.12
With a new Redactor update this should get fixed :)

https://forum.pulsecms.com/t/link-module-wysiwyg-not-working-correctly-with-https/908

@yuzoolcode yuzoolcode added the bug label Feb 5, 2018

@isilher

This comment has been minimized.

isilher commented Mar 8, 2018

Hi @yuzoolcode, I came across this issue searching for a solution in my own project. So far this hasn't been fixed by imperavi yet. I found the problem comes from the linkValidation that is by default 'fixing' any links you set. The following fixed the problem for me:

@element.redactor({
  // ...
  linkValidation: false,
})
@yuzoolcode

This comment has been minimized.

Owner

yuzoolcode commented Mar 8, 2018

Thanks for the note @isilher - we'll keep an eye on this one - have you tested this in latest Redactor 3?

@yuzoolcode

This comment has been minimized.

Owner

yuzoolcode commented Mar 13, 2018

Confirmed this still exists in Redactor 3.0.4

@oliver-77

This comment has been minimized.

oliver-77 commented Mar 13, 2018

This means that the hope of using codemirror is over. :(

@yuzoolcode

This comment has been minimized.

Owner

yuzoolcode commented Mar 13, 2018

Yes...

Redactor 3.0.4 added for Pulse 5.1 so unless they bring this back we have to use the standard code editor view.
But at least it fixes the line breaks... a compromise I guess

@yuzoolcode

This comment has been minimized.

Owner

yuzoolcode commented Mar 19, 2018

Not sure when this will be ready... waiting on them... This will make it in a future release but most likely not 5.1

@yuzoolcode

This comment has been minimized.

Owner

yuzoolcode commented Mar 21, 2018

Fixed in Pulse 5.1 with Redactor 3.0.5 onwards

@yuzoolcode yuzoolcode closed this Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment