New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing css error in admin - pulse 5.0.3 #24

Closed
jetwes opened this Issue Feb 7, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@jetwes

jetwes commented Feb 7, 2018

In the admin section there is an error for a missing css:
pulsecore/asset/vendor/node_modules/sweetalert/dist/sweetalert.css

There is no need to import an external css file for sweetalert2 any more - just disable the import in admin/index.php on line 79. The styles are bundled in JS with sweetalert2

Furthermore there is a deprecation warning for "confirmButtonText".
Fix:

confirmButtonText and cancelButtonText are no longer needed. Instead, you can set button: "foo" to set the text on the confirm button to "foo", or buttons: ["foo", "bar"] to set the text on the cancel button to "foo" and the text on the confirm button to "bar".

Info: https://sweetalert.js.org/guides/#upgrading-from-1x

@yuzoolcode

This comment has been minimized.

Owner

yuzoolcode commented Feb 8, 2018

Will add this is next update

@yuzoolcode

This comment has been minimized.

Owner

yuzoolcode commented Feb 24, 2018

Added in 5.1

@yuzoolcode yuzoolcode closed this Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment