New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't link to files inside Media folder #31

Closed
GRMacGeek opened this Issue Feb 23, 2018 · 9 comments

Comments

Projects
None yet
3 participants
@GRMacGeek

GRMacGeek commented Feb 23, 2018

Okay if I upload an image or pdf into the Media folder, and then try to set a link to it from within a block, the "pulse" part of the URL gets rewritten as "???"

For example

You can see this in action on this hidden page and half way down the page I tried to add a link for "Executive Director Job Description here"
My work around on the "live" page was to put the pdf in a different folder outside of Pulse and link to that, but my clients need to be able to add media and link to it...

@jrondorf

This comment has been minimized.

Collaborator

jrondorf commented Feb 23, 2018

I have seen this before. This ??? is only generated inside the RW page, or also in a Pulse page?
How did you inserted the link in Redactor?

@GRMacGeek

This comment has been minimized.

GRMacGeek commented Feb 23, 2018

Link entered in Redactor, and looks fine even when you view the html See attached images
pulse_cms
pulse_cms2

But when you view it live on the website the "pulse" part of the link gets changed to "???" for some reason...
I tried it with a few different media files, and always the same result.

@jrondorf

This comment has been minimized.

Collaborator

jrondorf commented Feb 24, 2018

Again, is it in your case only rendered inside RW wrong, or also on a plain pulse page?

@GRMacGeek

This comment has been minimized.

GRMacGeek commented Feb 24, 2018

Okay not sure what you are trying to ask here...

Yes this is a Pulse block in Rapidweaver. But it can't obviously "render" in Rapidweaver, the issue happens when you view the "live" link on the website. Even though the link is correct in the block, and stays correct even after I save it, it changes on the live website... test page "rendered" here

@jrondorf

This comment has been minimized.

Collaborator

jrondorf commented Feb 24, 2018

I am trying to find out if it is a general pulse problem, or if the problem only is related to a block displayed inside RW.

What happens if you put that block with the link in a Pulse page and view it in http://domain/pulse/page ?

@GRMacGeek

This comment has been minimized.

GRMacGeek commented Feb 24, 2018

How do I add a "Pulse Page" to a Rapidweaver project?

@jrondorf

This comment has been minimized.

Collaborator

jrondorf commented Feb 24, 2018

@yuzoolcode This is a bug in block.txt generation. After you enter the link in the admin dashboard, it gets corrupted.

When adding a link like this:

2018-02-24_14-32-10

And the block looks like this:

2018-02-24_14-32-25

The block save process generated a wrong link inside the text file. Why is {{show_var:path}} automatically inserted here?

<p>This is the link:</p><p><a href="http:/{{show_var:path}}5.instacks.com{{show_var:path}}/content/media/documents/document.pdf">Document</a><br></p>

@jrondorf

This comment has been minimized.

Collaborator

jrondorf commented Feb 24, 2018

Repository owner deleted a comment from jrondorf Mar 1, 2018

Repository owner deleted a comment from jrondorf Mar 1, 2018

@jrondorf

This comment has been minimized.

Collaborator

jrondorf commented Mar 5, 2018

Fixed for 5.1. Thanks for retest!

@yuzoolcode yuzoolcode closed this Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment