Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gl_rasterizer: Fix stencil testing #2833

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@ReinUsesLisp
Copy link
Contributor

commented Sep 4, 2019

  • Fix stencil dirty flags tracking when stencil is disabled
  • Attach stencil on clears (previously it only attached depth)
  • Attach stencil on drawing regardless of stencil testing being enabled

This fixes Puyo Puyo Tetris and Cadence of Hyrule
imagen
imagen

@ReinUsesLisp ReinUsesLisp added the gpu-fix label Sep 4, 2019
Copy link
Contributor

left a comment

lgtm

* Fix stencil dirty flags tracking when stencil is disabled
* Attach stencil on clears (previously it only attached depth)
* Attach stencil on drawing regardless of stencil testing being enabled
@ReinUsesLisp ReinUsesLisp force-pushed the ReinUsesLisp:fix-stencil branch from 8c52606 to 7bbc98c Sep 4, 2019
Copy link
Contributor

left a comment

LGTM

@bunnei
bunnei approved these changes Sep 5, 2019
@bunnei bunnei merged commit 03badbd into yuzu-emu:master Sep 5, 2019
5 of 6 checks passed
5 of 6 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
yuzu verify Build #20190904.23 succeeded
Details
yuzu verify (build standard linux) build standard linux succeeded
Details
yuzu verify (build standard windows) build standard windows succeeded
Details
yuzu verify (build testing windows) build testing windows succeeded
Details
yuzu verify (format clang) format clang succeeded
Details
@ReinUsesLisp ReinUsesLisp deleted the ReinUsesLisp:fix-stencil branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.