Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shader/image: Implement SULD and fix SUATOM #2869

merged 3 commits into from Sep 24, 2019


Copy link

commented Sep 18, 2019

Implements SULD (imageLoad) using GL_EXT_shader_image_load_formatted when available. While we are at it, fix SUATOM related GLSL build issues.

This removes the image format guessing and always uses r32ui when atomic operations are present. Operations that will require signed/unsigned distinction (e.g. MIN) will have to use a compare-and-swap loop. The implementation for these has been removed until we find a game using it.


This comment has been minimized.

Copy link

commented Sep 21, 2019

Rebase please @ReinUsesLisp

* Implement SULD as float.
* Remove conditional declaration of GL_ARB_shader_viewport_layer_array.
In the process remove implementation of SUATOM.MIN and SUATOM.MAX as
these require a distinction between U32 and S32. These have to be
implemented with imageCompSwap loop.
@ReinUsesLisp ReinUsesLisp force-pushed the ReinUsesLisp:suld branch from 9cc1950 to 4400097 Sep 21, 2019
bunnei approved these changes Sep 24, 2019
@bunnei bunnei merged commit 376f1a4 into yuzu-emu:master Sep 24, 2019
5 checks passed
5 checks passed
yuzu verify Build #20190921.19 succeeded
yuzu verify (build standard linux) build standard linux succeeded
yuzu verify (build standard windows) build standard windows succeeded
yuzu verify (build testing windows) build testing windows succeeded
yuzu verify (format clang) format clang succeeded
@ReinUsesLisp ReinUsesLisp deleted the ReinUsesLisp:suld branch Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
5 participants
You can’t perform that action at this time.