Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of Ioctl2 & Ioctl3 #2873

Merged
merged 4 commits into from Sep 22, 2019

Conversation

@ogniK5377
Copy link
Contributor

commented Sep 19, 2019

Purpose of Ioctl2 and Ioctl3 is to prevent the passing of raw pointers through ioctls.

For Ioctl2, instead of Nintendo passing a pointer to KickoffPB, they now pass a second buffer containing the command list.

For Ioctl3, Nintendo writes to an output buffer instead of a pointer.

Currently KickoffPB and GetCharacteristics have been updated as those are the only two observed functions which have been changed as of now. As more ioctls get called, we will need to update them accordingly.

Purpose of Ioctl2 and Ioctl3 is to prevent the passing of raw pointers through ioctls
@ogniK5377

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2019

Note, the file is clang formatted. Unsure why it's failing with azure

@ogniK5377

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2019

Do not merge until the clang-format issue has been looked into further

@ogniK5377

This comment has been minimized.

Copy link
Contributor Author

commented Sep 22, 2019

Matched clang-format from the server, this should be looked at in the future

@ogniK5377 ogniK5377 removed the do-not-merge label Sep 22, 2019
@FernandoS27 FernandoS27 merged commit a755f24 into yuzu-emu:master Sep 22, 2019
5 checks passed
5 checks passed
yuzu verify Build #20190922.8 succeeded
Details
yuzu verify (build standard linux) build standard linux succeeded
Details
yuzu verify (build standard windows) build standard windows succeeded
Details
yuzu verify (build testing windows) build testing windows succeeded
Details
yuzu verify (format clang) format clang succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.