Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added frame_count for REV5 audio renderer #2877

Merged
merged 2 commits into from Sep 22, 2019

Conversation

@ogniK5377
Copy link
Contributor

commented Sep 20, 2019

Added framecount. Need a game to actually read it to confirm that this is the frame count

Added framecount
@ogniK5377

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2019

This fixes most 8.0.1 games which break on audren request update

@@ -107,6 +107,11 @@ Stream::State AudioRenderer::GetStreamState() const {
return stream->GetState();
}

constexpr u32 VersionFromRevision(u32_le rev) {

This comment has been minimized.

Copy link
@lioncash

lioncash Sep 20, 2019

Contributor

This needs to be marked static, otherwise this has external linkage.

@Hexagon12 Hexagon12 added the audio-new label Sep 20, 2019
@ogniK5377 ogniK5377 changed the title Added frame_count for REV7 audio renderer Added frame_count for REV5 audio renderer Sep 21, 2019
@ogniK5377

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2019

Games from REV5 use this according to audren 8.0.1

@ogniK5377 ogniK5377 added canary-merge and removed canary-merge labels Sep 21, 2019
Copy link
Contributor

left a comment

Code LGTM

@DarkLordZach DarkLordZach merged commit b772581 into yuzu-emu:master Sep 22, 2019
5 checks passed
5 checks passed
yuzu verify Build #20190921.3 succeeded
Details
yuzu verify (build standard linux) build standard linux succeeded
Details
yuzu verify (build standard windows) build standard windows succeeded
Details
yuzu verify (build testing windows) build testing windows succeeded
Details
yuzu verify (format clang) format clang succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.