Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader_IR: Implement ICMP.Instruction #2878

Merged
merged 2 commits into from Sep 21, 2019

Conversation

@FernandoS27
Copy link
Contributor

commented Sep 20, 2019

This PR implements ICMP instruction.

UNIMPLEMENTED_IF(instr.icmp.is_signed != 0);
const Node zero = Immediate(0);

const auto [op_a, op_b] = [&]() -> std::tuple<Node, Node> {

This comment has been minimized.

Copy link
@lioncash

lioncash Sep 20, 2019

Contributor
Suggested change
const auto [op_a, op_b] = [&]() -> std::tuple<Node, Node> {
const auto [op_a, op_b] = [&]() -> std::pair<Node, Node> {

generally requires less template instantiation work by the compiler.

@Hexagon12 Hexagon12 added the gpu-new label Sep 20, 2019
@FernandoS27 FernandoS27 force-pushed the FernandoS27:icmp branch from 2f9b079 to 9709fda Sep 20, 2019
case OpCode::Id::ICMP_IMM:
return {Immediate(instr.alu.GetSignedImm20_20()), GetRegister(instr.gpr39)};
default:
UNIMPLEMENTED();

This comment has been minimized.

Copy link
@ReinUsesLisp

ReinUsesLisp Sep 21, 2019

Contributor

This would be UNREACHABLE.

@FernandoS27 FernandoS27 force-pushed the FernandoS27:icmp branch from 9709fda to 527b841 Sep 21, 2019
@ReinUsesLisp ReinUsesLisp merged commit 9286976 into yuzu-emu:master Sep 21, 2019
5 checks passed
5 checks passed
yuzu verify Build #20190921.17 succeeded
Details
yuzu verify (build standard linux) build standard linux succeeded
Details
yuzu verify (build standard windows) build standard windows succeeded
Details
yuzu verify (build testing windows) build testing windows succeeded
Details
yuzu verify (format clang) format clang succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.