Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fermi2D: limit blit area to only available area #2914

Open
wants to merge 1 commit into
base: master
from

Conversation

@FernandoS27
Copy link
Contributor

commented Sep 27, 2019

Normaly OpenGL does not care if the areas exceed the texture regions but other backends such as Vulkan do care about the limits of this areas. This PR crops the areas of the blit in order that they don't surpass the limits of the textures. This should help Vulkan and faulty OpenGL drivers.

@CLAassistant

This comment has been minimized.

Copy link

commented Sep 30, 2019

CLA assistant check
All committers have signed the CLA.

@bunnei
bunnei approved these changes Oct 1, 2019
Normaly OpenGL does not care if the areas exceed the texture regions but
other backends such as Vulkan do care about the limits of this areas.
This PR crops the areas of the blit in order that they don't surpass the
limits of the textures. This should help Vulkan and faulty OpenGL
drivers
@FernandoS27 FernandoS27 force-pushed the FernandoS27:fermi-fix branch from 4e3310a to 38137a7 Oct 4, 2019
@ReinUsesLisp

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

I'm not sure this is the right approach. src and dest are off by one pixel, e.g.: [-1,1279]. It looks more like an issue in the code above these changes.

@FernandoS27

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2019

I'm not sure this is the right approach. src and dest are off by one pixel, e.g.: [-1,1279]. It looks more like an issue in the code above these changes.

I could look at my logical, it could also mean our base equations may be wrong. Some hardware tests could do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.