Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate missing migrations #21

Merged

Conversation

naegelyd
Copy link

@yvandermeer cc @arpheno

Fix #19

There are three alterations happening in the migrations here. I will address each one separately:

  1. Change the verbose_name on RequestParameter.name from naam to name.
  2. Change the verbose_name on Response.content from inhoud to content.
  3. Change the verbose_name on Response.content_type from inhoudstype to content type.

Without these alterations, one will see the following warning when trying to run migrations if httpproxy is in their INSTALLED_APPS.

Running migrations:
    No migrations to apply.
    Your models have changes that are not yet reflected in a migration, and so won't be applied.
    Run 'manage.py makemigrations' to make new migrations, and then re-run 'manage.py migrate' to apply them.

This PR resolves that issue by adding the required migrations here to httpproxy.

@naegelyd
Copy link
Author

naegelyd commented Feb 9, 2016

Friendly ping @yvandermeer.

Any ETA in getting this reviewed and merged?

yvandermeer added a commit that referenced this pull request Feb 10, 2016
@yvandermeer yvandermeer merged commit d10bc3c into yvandermeer:develop Feb 10, 2016
@yvandermeer
Copy link
Owner

@naegelyd Sorry for the delay in merging this. Thanks for your pull request!

@naegelyd
Copy link
Author

@yvandermeer No problem. Thanks again for merging this in. Based on the timings on the releases, it looks like this change is in the 0.4.3 release. Could you push that release to pypi so we can pin our dependency to django-http-proxy==0.4.3 to make sure we get these migration changes?

@naegelyd naegelyd deleted the generate-missing-migration branch February 10, 2016 19:22
@yvandermeer
Copy link
Owner

Yes, sorry, forgot to mention that. I just pushed the 0.4.3 release to pypi, ready for consumption. 👍

@naegelyd
Copy link
Author

I just pushed the 0.4.3 release to pypi, ready for consumption.

Perfect! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running makemigrations raises permission denid
2 participants