Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a custom 404 page for this repo #23

Merged
merged 5 commits into from Dec 3, 2018
Merged

Conversation

@susantruong
Copy link
Contributor

susantruong commented Nov 21, 2018

Created a 404 error page for this GitHub page site #22

@ywpark1

This comment has been minimized.

Copy link
Owner

ywpark1 commented Nov 22, 2018

Thanks @susantruong ,

Can you elaborate more about this PR?

@humphd

This comment has been minimized.

Copy link

humphd commented Nov 22, 2018

@ywpark1 she's adding a static 404 page, so that if someone tries to open a URL on the gh-pages site that doesn't exist, you can give back a themed 404 that looks like the rest of your site vs. something generic. After this lands, you can style this HTML to match your template.

@ywpark1

This comment has been minimized.

Copy link
Owner

ywpark1 commented Nov 26, 2018

Can we have this with separate directory under the template directory?

We can add this file when generating process fails and users will see this page after pushing to the repository.

Updated 404.html file
@susantruong susantruong force-pushed the susantruong:issue-22 branch from 7b21ae7 to a46be23 Dec 1, 2018
@susantruong

This comment has been minimized.

Copy link
Contributor Author

susantruong commented Dec 1, 2018

@ywpark1 I am not sure where you want to put the 404.html file. Therefore, I have removed the 404.html file. Also, I created a new 404page folder that is including 404.html file and 404.png image and put it in 3 different following folders:

  1. 404page/
  2. Portfolio-generator-console/404page/
  3. templates/404page/

May you check it? Thanks.

@ywpark1

This comment has been minimized.

Copy link
Owner

ywpark1 commented Dec 3, 2018

Thanks @susantruong

I will merge it. Thanks.

@ywpark1 ywpark1 merged commit 7de977d into ywpark1:master Dec 3, 2018
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.