Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to specify the plantuml delimiter #104

Open
wants to merge 1 commit into
base: develop
from

Conversation

@andre-stoesel
Copy link

commented Aug 30, 2018

I created this pull request to solve the problem from issue #92.

The export of gitlab flavored markdown file with plantuml drawings work fine, if the opening delimiter is set to ```plantuml and the closing delimiter is set to ```.

@andre-stoesel andre-stoesel changed the base branch from master to develop Aug 30, 2018

@ChrisTuckerNM

This comment has been minimized.

Copy link

commented Oct 1, 2018

Approved yet? Implemented?

@paussems

This comment has been minimized.

Copy link

commented Dec 6, 2018

Would be nice if this patch gets merged

@bvella

This comment has been minimized.

Copy link

commented Dec 26, 2018

I am using this patch to be able to convert markdown files to pdf that use gitlab style diagrams, i.e. code block with plantuml language. Can this be merged or some feedback provided? I hate to have to ask developers to manually patch the plugin to be able to export a pdf

@PetrGasparik

This comment has been minimized.

Copy link

commented Mar 13, 2019

Please merge this patch.

BTW I tried to apply it by changing c:\Users<user>.vscode\extensions\yzane.markdown-pdf-1.2.0 foles and it didn!t help. I understand that I need markdown-it-plantuml plugin but how to get it? VSCode for windows

@anorm

This comment has been minimized.

Copy link

commented May 9, 2019

I would also love to see this patch merged. Using vscode with "PlantUML" jebbs.plantuml and "Markdown PDF" yzane.markdown-pdf extensions makes for a perfect combo.

@yzane yzane added this to the 1.2.1 milestone Sep 7, 2019

@yzane yzane added the enhancement label Sep 7, 2019

@patmuk

This comment has been minimized.

Copy link

commented Sep 17, 2019

Please release 1.2.1 as soon as possible, this is a highly desired feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.