Respect Inline Suggestion to improve compatibility with GitHub Copilot

[adam-coster]

Issue: The inline suggestions provided by GitHub Copilot cannot be used in Markdown files while Markdown All In One is active.

Feature Request: Can we get a config option to toggle allowing Tab to take inline suggestions?

Update (@yzhang-gh): It has been fixed in the dev build.

Background & Workaround

I changed the markdown.extension.onTabKey keyboard shortcut to add !inlineSuggestionVisible to the when conditions. This disables the Markdown extension's Tab behavior when Copilot is showing a suggestion, allowing the editor.action.inlineSuggest.commit binding on Tab to take over.

Whether or not this option gets added, for anyone else needing to enable Copilot or other inline-suggestion tools to work when using this extension, you can update your keybindings.json (Ctrl+Shift+p, then find Preferences: Open Keyboard Shortcuts (JSON)) by adding the following:

[
  {
    "key": "tab",
    "command": "markdown.extension.onTabKey",
    "when": "editorTextFocus && !inlineSuggestionVisible && !editorReadonly && !editorTabMovesFocus && !hasOtherSuggestions && !hasSnippetCompletions && !inSnippetMode && !suggestWidgetVisible && editorLangId == 'markdown'"
  },
  {
    "key": "tab",
    "command": "-markdown.extension.onTabKey",
    "when": "editorTextFocus && !editorReadonly && !editorTabMovesFocus && !hasOtherSuggestions && !hasSnippetCompletions && !inSnippetMode && !suggestWidgetVisible && editorLangId == 'markdown'"
  }
]

The first entry adds the !inlineSuggestionVisible condition, and the second entry essentially blocks the shortcut that comes with the Markdown All In One extension.

[adam-coster]

Additional reference from the VSCode repo: microsoft/vscode#131953

[yzhang-gh]

We can add the !inlineSuggestionVisible but I think we also need to ask VS Code to document it (what is its meaning and when is it used).

(should be available in the dev build now.)

[MitchTalmadge]

I've confirmed this works to solve the problem I was experiencing in microsoft/vscode#131953. Thank you for this solution.

[Lemmingh]

GitHub Copilot takes advantage of several proposed or private features of VS Code, such as Inline Suggestion (microsoft/vscode#124024).

In case of intense changes like microsoft/vscode#125498, we should keep this issue open until the finalization of these APIs, and also monitor the following:

• https://github.com/microsoft/vscode/labels/inline-completions

• https://github.com/microsoft/vscode/blob/32744a08fb90b549696d89d865b5ba3095946736/src/vs/editor/contrib/inlineCompletions/ghostTextController.ts#L188-L206

[JoyShaheb]

The Solution provided by @adam-coster worked for me, Thank you !

[Djcarrillo6]

Solution referenced above works for me as well! Thank you!!

[fonnesbeck]

This does not work for me on Windows (nor does uninstalling Markdown All In One).

[Franky1]

I tried the solution, but could not edit the keybindings.json file. VSCode says it is write protected. I found no option to unlock.

• OS Windows 10
• VSCode Version 1.63.2

EDIT: I was wrong, i was in the default keyboard settings...

[yzhang-gh]

Just a note, you can install the dev build to get the fix.

[sasukeh]

@adam-coster 's workaround is works for me for now! Thanks @adam-coster .

[Jont828]

Thanks @adam-coster. It worked for me!

[dlintin]

This solution is working great for me at the time! for those who on mac can use (⇧⌘P) to select the Preferences: Open Keyboard Shortcuts (JSON)

[laakal]

It's also conflicts with the docs-markdown extension. It works after deleting the docs-markdown extension.

[andig]

Checking in here. It would be nice to get copilot compatibility out of the box.

[anbarasanv]

Thank you very much works fine for me on my Mac.

[yzhang-gh]

has been fixed in v3.4.2

[MitchTalmadge]

Thank you so much

[Lemmingh]

The Inline Completions API is finalized in VS Code May 2022 (version 1.68) released this weekend.

No noticeable changes.

• https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_68.md

• API InlineCompletions Finalised microsoft/vscode-discussions#26

• https://github.com/microsoft/vscode/blob/15d3e26a36a7a69a355eee501741a77d39fbd9a0/src/vs/editor/contrib/inlineCompletions/browser/ghostTextController.ts#L23-L25

---

Sigh: It has been one year.