Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto open preview makes commenting on Github PR for `.md` files impossible #542

Open
ProLoser opened this issue Oct 25, 2019 · 1 comment

Comments

@ProLoser
Copy link

@ProLoser ProLoser commented Oct 25, 2019

What is the problem?

I am using the Github PullRequests extension for VSCode. When I open a .md file a preview auto-opens (this is fine). However when I try to comment on the file, whenever I focus on the inline comment box, the preview pane immediately steals focus away.

Please detect when I'm typing into a PR line comment before re-rendering or stealing focus.

How can I reproduce it?

  1. Install Github Pull Requests
  2. In the PR browser, select a .md file from an open PR.
  3. Markdown Preview should auto-open next to diff
  4. Click the [+] button on a line number in the diff to add a comment
  5. Click on the textarea to begin writing the comment
  6. Markdown Preview steals focus away from the textarea
@yzhang-gh

This comment has been minimized.

Copy link
Owner

@yzhang-gh yzhang-gh commented Oct 26, 2019

Thanks for the feedback.

It doesn't look like a problem of this extension. (The only thing this extension does is overriding the default Show Preview keybindings.)

Can you disable this extension and see whether the issue is still there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.