Conflict with Tab Completion

[sfsccn]

What is the problem?

When the extension is enabled snippet tab completion does not work in markdown files. Typing part of the snippet followed by tab does nothing. The same is true if editor.tabCompletion=on. If editor.tabCompletion=onlySnippets, then typing the full snippet followed by tab brings up the suggestion list you normally see with CTRL+space. So basically nothing about snippet tab completion works as expected when the extension is enabled. If I disable the extension, snippet tab completion works as expected.

I tested mainly with remote Linux files but the same issue occurred in local Windows files.

settings.json

    "[markdown]": {
        "editor.snippetSuggestions": "inline",
        "editor.tabCompletion": "onlySnippets",
        "editor.quickSuggestions": false
    }

How can I reproduce it?

• Apply the settings above
• Enable the extension
• Create a markdown snippet like "pcode"
• Edit a markdown file
• Type "pc" + TAB. Expected: inserts the best matching snippet. Actual: nothing.
• Type "pcode" + TAB. Expected: inserts pcode snippet. Actual: suggestion list like CTRL+Space.
• Disable extension
• Repeat above and get the expected behavior.

Results are the same in the Insiders build.

Is there any error message in the console?

No.

• OS: Windows 10
• Remote: Ubuntu 19.10
• VS Code: 1.44.2
• Insiders: 1.45.0
• Markdown AIO: 2.8

[yzhang-gh]

Thanks for the feedback.

This extension does override the tab key, but only when editorTextFocus && !editorReadonly && !editorTabMovesFocus && !hasOtherSuggestions && !hasSnippetCompletions && !inSnippetMode && !suggestWidgetVisible && editorLangId == 'markdown'.
In theory, it should not conflict with the default insertSnippet command which has conditions editorTextFocus && hasSnippetCompletions && !editorTabMovesFocus && !inSnippetMode.

However, I can reproduce the issue you reported. That's strange.

A workaround is to remove onTabKey keybinding by yourself.

[sfsccn]

Thanks for the info. I'm not sure what value to assign to markdown.extension.onTabKey. Using false has no apparent effect. Also, I'm getting an "unknown configuration setting" message when I enter that in settings.json.

It's not a big problem for me, I'm just using quickSuggestions instead of tabCompletion for now.

The extension's been very useful, thanks.

[yzhang-gh]

I'm not sure what value to assign to markdown.extension.onTabKey.

It's usually used to indent a list item

To remove a keybinding, you need to use the "keyboard shortcuts" page (rather than settings.json)

It's not a big problem for me, I'm just using quickSuggestions instead of tabCompletion for now.

Good to hear that.

[sfsccn]

Hi, I ended up using your suggestion of removing the tab keyboard shortcut as quickSuggestions was driving me nuts. It works great now with tab completion for snippets. Thanks!

[yzhang-gh]

Glad to hear that.