Ordinary list whose first item looks like the first heading is detected as TOC

[Ytrog]

When I have a header with a list beneath it containing links it seems to think it is a TOC (marking it as not up to date) and regenerating a TOC in place on saving. You should be able to save without it creating TOC's.

Example:

## Tasks
- [A task](http://link-to-task)
- [Another task](http://link-to-another-task)

On saving this is replaced by a TOC of the entire document.

Edit
Got it disabled using:
"markdown.extension.toc.updateOnSave": false

However it's still strange it detected a TOC here.

[yzhang-gh]

Thank you for the feedback. I'll look into it this weekend.

[yzhang-gh]

It seems that I cannot reproduce that with the snippet you provided 🤔.
Could you please provide more details? (e.g. vscode version, the text which was misrecognized as TOC)

[Ytrog]

VSCode 1.13.1

As I don't want to leak information I obfuscated the actual text (it shouldn't really matter):

[yzhang-gh]

Okay, I see the bug.
But I have no idea about why. Can you try to reproduce it with some not secret text? 😅

---

Below is the current behaviors,

To avoid distractive HTML comments, this extension will 'guess' where the TOC is. Currently, a TOC will be recognized if

• It's a list block in Markdown syntax
• Its first list item title matches the first heading in the file

[Ytrog]

Ah, the first item matches the title (a level 1 header) so the second rule triggers.

It would be like

# PR-123456 Build a new window

## Issues
- [PR-123456 Build a new window](http://issuetracker/PR-123456)
- [PR-123457 A related issue](http://issuetracker/PR-123457)

Too bad markdown doesn't have comments or it would be possible to make a NoTOC tag that doesn't show in the output.

[yzhang-gh]

I'll add an additional rule which is

• It should be a within-document anchor (something like #header-title) not a link (http://...)

[Ytrog]

I like the idea 👍

[yzhang-gh]

I've fixed it. But I cannot publish the new version because of the bad network connection. Let's ship it tomorrow.

[yzhang-gh]

Published! If you are satisfied with it, please give me a 5 stars 😉

[Ytrog]

It seems fixed 😄

Amended my review ;)

[yzhang-gh]

Thanks 😎