Missing semicolons #116

Closed
Niggler opened this Issue Sep 25, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

Niggler commented Sep 25, 2012

There are a few points where semicolons are missing.

I wrote it in the form ' + ";"' to make it clear which semicolon needs to be added

  1. in the exports.main assignment
    + "\nexports.main = "+ String(opt.moduleMain || commonjsMain)

This line should have a semicolon:

    + "\nexports.main = "+ String(opt.moduleMain || commonjsMain)+ ";"
  1. exports.parse = ....
    + "\nexports.parse = function () { return "+moduleName+".parse.apply("+moduleName+", arguments); }"

This line should have a semicolon:

    + "\nexports.parse = function () { return "+moduleName+".parse.apply("+moduleName+", arguments); }" + ";"
  1. var lexer = ....
    out += ";\nreturn lexer;})()" + ";";
  1. in buildActions, the "var YYSTATE=YY_START" line:
   var actions = [dict.actionInclude || '', "var YYSTATE=YY_START" + ";"];
Owner

zaach commented Sep 25, 2012

This would make for a good first patch if someone wants to do the honors. :)

Contributor

Niggler commented Sep 25, 2012

See the pull request for the changes.

Niggler closed this Sep 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment