Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pullreq 8: manual extract of one section of stuff hiding in #143: jquery.live, USF revival, assets/web code updated #144

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

GerHobbelt commented Feb 16, 2013

See also the commit message itself. I saw that there was a lot hiding under the rug in #143 due to the git merge process I use; here's the manual extract of most of the goodies. (The submodules/makefile work is not included as that's probably too much 'It Works Here(tm)' now)


  • jQuery.live() has been obsoleted for a very long time; now it's DEAD since 1.9.x --> using the suggested .on() etc. methods instead
  • fixing the completely b0rked code in jison.js @ line 1509 onwards: no 'break's in the cases = OOCH!
  • semicolon goodness (and one semicolon that was misplaced)
  • synced the lexer/parser code in the assets dirtree with my/thy? latest
  • provided explicit link to the 'old-now-new' USF page and fixed it so it works again as the parser state analysis available is just way too valuable to throw away: you get to see the LR parser states and can click on them to see what's going on in there. VERY handy when diagnosing sick grammars.

P.S.: if anything is broken in this merge, than it's most probably due to me using relative links in my repo as I have the jison 'website' as a SUBsite (rather a bunch of pages in a subdirectory than 'subsite' in the webserver sense!) of our company's project dev 'site' so all /jison/ links in there were completely broken for me.

GerHobbelt added some commits Feb 16, 2013

manual extract of these (all related to the assets/ and web/content/ …
…directories):

- jQuery.live() has been obsoleted for a very long time; now it's DEAD since 1.9.x --> using the suggested .on() etc. methods instead

- fixing the completely b0rked code in jison.js @ line 1509 onwards: no 'break's in the cases = OOCH!

- semicolon goodness (and one semicolon that was misplaced)

- synced the lexer/parser code in the assets dirtree with my/thy? latest

- provided explicit link to the 'old-now-new' USF page and fixed it so it works again as the parser state analysis available is just way too valuable to throw away: you get to see the LR parser states and can click on them to see what's going on in there. VERY handy when diagnosing sick grammars.

P.S.: if anything is broken in this merge, than it's most probably due to me using relative links in my repo as I have the jison 'website' as a SUBsite (rather a bunch of pages in a subdirectory than 'subsite' in the webserver sense!) of our company's project dev 'site' so all /jison/ links in there were completely broken for me.

---

The list of commits that fed this:

SHA-1: 57aee14

* moved the USF images to the pngs/ asset directory + corrected the nanoc rules to ensure the try/usf page is properly regenerated -- that's the page where you can see the diagnostics of the jison run (state machine), so it's quite handy to have around.

SHA-1: e7023d5

* regenerated & tested all required files via 'make' + 'make site'

SHA-1: 4423427

* updated website code ('make site')

SHA-1: 5775f2f

* updated the website pages following the latest changes (verified to work using the included tests)

SHA-1: b4f5034

* copied the 'relative path' code from gh-pages back to the nanoc sources (TBD: get the layout to work for a/b/ subdirs again)

This copying includes the USF page updates (style, content and code) and the TRY page updates (linking to the USF page as that one is pretty useful during development)

SHA-1: cebf52c

* updated jquery copy xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

SHA-1: 62a610a

* http://api.jquery.com/live/ : .live() is long gone deprecated. Now it is finally removed and the code had to be changed to use .on() like it should.

@zaach zaach commented on the diff Feb 16, 2013

web/content/assets/js/lib/jison.js
case 'lalr':
default:
gen = new LALRGenerator(g, opt);
+ break;
@zaach

zaach Feb 16, 2013

Owner

Woah, this is a really outdated version.

Owner

zaach commented Feb 16, 2013

The jison files under assets/js will be browserified soon, so most of those files will go away. The changes you landed via PRs will be reflected in the generated scripts, once I get browserify working.

The jquery updates are very much welcome.

Contributor

GerHobbelt commented Feb 18, 2013

No worries, mate. ;-)

What you see here is my usual process when the turd hits the blender: when
things start to play up and do so more than once, I go in and do a (few
times faulty) code review of the whole shebang to get a solid base for my
quality assessment. During that phase, when I hit something odd, I tackle
it irrespective of current pressing need because I've had way too many
experiences where I did it like 'everybody else' and just fixed what I
needed fixed and then got bitten in the pectoral quite some time later. And
bitten hard. Because by then I'd forgotten about the subtle
relationships/links and had to go in and do some very strenuous
debugging/analysis. Multiple times.

I started looking at jison in sep/2012, using jison in nov/2012 and pulling
out the stops in dec/12. The 'how to sync/update everything' process was,
ah, 'reverse engineered' from the Makefile by me, so this might also be a
screwup due to misbehaviour on my part.

That was also how I ran into the USF page and since we were in the process
of testing jquery 1.9.x on our own codebase at the time, jison got 'hit' as
a side-effect of project-global search for string '.live' and the a clone
of the above process got booted.

Anyway, that's the context; throw away what you don't need or know is going
to be gone in measurable time. ;-)

Met vriendelijke groeten / Best regards,

Ger Hobbelt


web: http://www.hobbelt.com/
http://www.hebbut.net/
mail: ger@hobbelt.com

mobile: +31-6-11 120 978

On Sat, Feb 16, 2013 at 7:30 PM, Zach Carter notifications@github.comwrote:

The jison files under assets/js will be browserified soon, so most of
those files will go away. The changes you landed via PRs will be reflected
in the generated scripts, once I get browserify working.

The jquery updates are very much welcome.


Reply to this email directly or view it on GitHubhttps://github.com/zaach/jison/pull/144#issuecomment-13664852.

I am second to say that USF page rocks. It should be linked from the try page no doubts.

Owner

zaach commented Apr 17, 2013

Hey @GerHobbelt ! I went ahead and cherry picked some of these commits. Thanks!

@zaach zaach closed this Apr 17, 2013

Contributor

GerHobbelt commented Apr 17, 2013

You're welcome!

I hope you cherrypicked as much as possible ;-) -- anyway, I'll check/compare our code bases when I can come up for air again. That'll be several weeks from now, best case, though. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment