Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit bridging PMs (but poorly implemented) #34

Open
wants to merge 1 commit into
base: master
from

Conversation

@Zarthus
Copy link
Contributor

commented Jul 25, 2019

In case you also want to bridge PMs, I wrote this dirty hack to do it. It basically lets you map private-messages to a discord channel.

It builds on top of my other PR (#33) so that one should be handled first.

https://www.youtube.com/watch?v=-N0yXGVWS1Y

You can reject this PR if you don't like it and it doesn't maintain the code quality standards of what you'd like to have in the project, I don't really have any intention of fixing the implementation to be less hacky, as the purpose here is purely selfish.

@lol768

lol768 approved these changes Jul 25, 2019

val sender = BOT_SENDER
var topicSetter = ""
if (event.topic.setter.isPresent) {
topicSetter = " set by " + event.topic.setter.get().name

This comment has been minimized.

Copy link
@lol768

lol768 Jul 25, 2019

Seems cleaner to put the leading space in elsewhere

@Zarthus Zarthus force-pushed the Zarthus:bridge-pms branch from 5e228d8 to c4df14f Jul 30, 2019

@Zarthus Zarthus force-pushed the Zarthus:bridge-pms branch from c4df14f to ea554d2 Aug 11, 2019

@zachbr

This comment has been minimized.

Copy link
Owner

commented Aug 15, 2019

Hey sorry for the delay, life is crazy at the moment. I don't have any problems with the idea, the implementation isn't as bad as I imagined based on your description.

The thing I'm seeing right now offhand is that there's no handling for when the user has multiple private-message channels bridged.
There's probably some other minor tweaking, I am interested I just don't have a timeline for anything at the moment. Thanks for your work.

@zachbr zachbr added the feature label Aug 15, 2019

@Zarthus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.