Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Permit bridging PMs (but poorly implemented) #34
In case you also want to bridge PMs, I wrote this dirty hack to do it. It basically lets you map
It builds on top of my other PR (#33) so that one should be handled first.
You can reject this PR if you don't like it and it doesn't maintain the code quality standards of what you'd like to have in the project, I don't really have any intention of fixing the implementation to be less hacky, as the purpose here is purely selfish.
Hey sorry for the delay, life is crazy at the moment. I don't have any problems with the idea, the implementation isn't as bad as I imagined based on your description.
The thing I'm seeing right now offhand is that there's no handling for when the user has multiple
No worries, this has no urgency for me. Part of the reason I think it's poorly implemented is because it lacks the polish it needs. For me, this is just a "I need it somehow and I don't care if its not perfect" So it's missing intuitivity, proper docs, and another issue it has is that it stringifies the actor, but discord names are limited. So you end up with no ideal bridge messages. Hence, poorly implemented ;)…
On Thu, 15 Aug 2019, 02:40 Zach, ***@***.***> wrote: Hey sorry for the delay, life is crazy at the moment. I don't have any problems with the idea, the implementation isn't as bad as I imagined based on your description. The thing I'm seeing right now offhand is that there's no handling for when the user has multiple private-message channels bridged. There's probably some other minor tweaking, I am interested I just don't have a timeline for anything at the moment. Thanks for your work. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#34?email_source=notifications&email_token=AA35U6GX3B4QNV4LOO2ZRC3QESQZDA5CNFSM4IG5Z65KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4KQFTA#issuecomment-521470668>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA35U6AOWEN6AIH54DFCOV3QESQZDANCNFSM4IG5Z65A> .