Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge Extra IRC Events: QUIT, KICK, TOPIC, MODE #33 #35

Merged
merged 6 commits into from Jul 31, 2019

Conversation

@Zarthus
Copy link
Contributor

commented Jul 29, 2019

Adds bridging of KICK, QUIT

Optionally bridge TOPIC, MODE with the announce-extras config

Also fixes a typo in a file name

Feel free to cherry pick specific changes you're interested in. I'm not sure why the CI is failing.

Zarthus and others added some commits Jul 25, 2019

@Zarthus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

@zachbr
topic bridging is already behind a config option that's off by default (announce-extras)

@Zarthus Zarthus changed the title 2 Bridge Extra IRC Events: QUIT, KICK, TOPIC, MODE #33 Jul 29, 2019

@zachbr

This comment has been minimized.

Copy link
Owner

commented Jul 29, 2019

You are entirely correct on that. I just glanced right over that.

@Zarthus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

@zachbr So what are the next steps?

@zachbr

This comment has been minimized.

Copy link
Owner

commented Jul 29, 2019

Just gotta test and merge at this point. Should be soon.

@Zarthus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

sidenote: Logging your own quit may be useful to determine if the bridge bot died. (currently I skip it; it doesn't seem to deal with Ctrl-C's but it probably would log timeouts)

@zachbr

zachbr approved these changes Jul 31, 2019

@zachbr zachbr merged commit 4a4762e into zachbr:master Jul 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zachbr

This comment has been minimized.

Copy link
Owner

commented Jul 31, 2019

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.