Refactoring plain html to content_tag #24

merged 3 commits into from Feb 7, 2012

3 participants


No description provided.


@zachinglis When do you plan to merge it?


Soon. I've been ridiculously sick with a kidney infection.


Get well sooner!

@zachinglis zachinglis merged commit ff9d33a into zachinglis:master Feb 7, 2012

This change broke both the :html_list functionality and a test.

The problem is that the * operator on line 56 performs a join on the Array, returned by the collect block, which in turn returns a new String (which is not html_safe).

Please also see:

I see your patch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment