Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add class attribute to the img element #4

Merged
merged 3 commits into from Dec 5, 2012

Conversation

@trumbitta
Copy link
Contributor

commented Dec 4, 2012

hacked this in to support - for example - the handy class="img-polaroid" from Twitter Bootstrap

@zachleat

This comment has been minimized.

Copy link
Owner

commented Dec 4, 2012

Remember, you can do $.gravatar('youremail@example.com').addClass('anything');

But also, I don't see classes used anywhere?

forgot to add this little bit when porting from my own experiment into this fork
@trumbitta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 4, 2012

Lol I'm sorry. I forgot to add that second bit.
I hacked this in my own little project a few days ago, and just now I forked your repo and submitted the pull-request.

@zachleat

This comment has been minimized.

Copy link

commented on jquery.gravatar.js in 9118580 Dec 4, 2012

I think it should be (options.classes ? ' class="' + options.classes + '"' : '') +

Note the space before class

@zachleat

This comment has been minimized.

Copy link
Owner

commented Dec 4, 2012

No worries!

zachleat added a commit that referenced this pull request Dec 5, 2012
add class attribute to the img element
@zachleat zachleat merged commit cd50f04 into zachleat:master Dec 5, 2012
@zachleat

This comment has been minimized.

Copy link
Owner

commented Dec 5, 2012

Thanks!

@trumbitta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 5, 2012

thanks to you! Your plugin relieved me of the hassle of handling my gravatar image in like seconds 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.