Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow working with trolleybus routes #7

Open
HellMapGoesCoding opened this issue Jun 20, 2023 · 4 comments
Open

Allow working with trolleybus routes #7

HellMapGoesCoding opened this issue Jun 20, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@HellMapGoesCoding
Copy link

HellMapGoesCoding commented Jun 20, 2023

I noticed when trying to load a trolleybus route that it returned that it wasn't a valid bus route. I am not certain, but I think there should be no difference between bus and trolleybus route processing - they do exactly the same thing. I should mention that I realize this is on the planned list, but this seems like a very low-hanging fruit, considering it's (probably) just another route value and can otherwise be treated the same.

@Zaczero
Copy link
Owner

Zaczero commented Jun 21, 2023

Please provide me an example route and I'll see what I can do :-)

@Zaczero Zaczero added the enhancement New feature or request label Jun 21, 2023
@HellMapGoesCoding
Copy link
Author

Sure thing! Here are the two routes I was playing with yesterday: https://www.openstreetmap.org/relation/16001026 and https://www.openstreetmap.org/relation/16001027 . I had them set as route=bus to load them. I've changed them now back to route=trolleybus.

Thinking some more, perhaps I spoke too soon about the only change. The stop/platform itself would get a trolleybus=yes instead of bus=yes. I am not sure though if Relatify is actually adding bus=yes to stops to begin with? And whether it should consider existing bus/trolleybus values (I think you ignore bus=no, but otherwise any stop will do?).

@Dimitar5555
Copy link
Contributor

Here is also another set of them https://www.openstreetmap.org/relation/3493882.

@Zaczero Is there any particular difficulty with adding support for trolleybus routes? Assuming the problem is how to select the streets - just look for trolley_wire or trolleybus. trolleybus=yes seems to be used on road segments where trolleybuses don't run under overhead wires and use batteries (or diesel generator).

@Zaczero
Copy link
Owner

Zaczero commented Sep 11, 2023

I simply haven't focused on this specific issue yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants