Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply directives skip/include for mutation #172

Merged
merged 1 commit into from May 24, 2022
Merged

Conversation

boopathi
Copy link
Member

@boopathi boopathi commented May 20, 2022

@boopathi
Copy link
Member Author

👍

3 similar comments
@ruiaraujo
Copy link
Collaborator

👍

@oporkka
Copy link
Member

oporkka commented May 24, 2022

👍

@oporkka
Copy link
Member

oporkka commented May 24, 2022

👍

@boopathi boopathi merged commit 970d4e4 into main May 24, 2022
@boopathi boopathi deleted the fix-mut-directives branch May 24, 2022 15:44
boopathi added a commit that referenced this pull request May 24, 2022
- fix: parse Date scalar object arguments properly (#158)
- fix: apply directives skip/include for mutation (#172)
- upgrade dependencies: minimist, async, fast-json-stringify
@boopathi boopathi mentioned this pull request May 24, 2022
boopathi added a commit that referenced this pull request May 24, 2022
- fix: parse Date scalar object arguments properly (#158)
- fix: apply directives skip/include for mutation (#172)
- upgrade dependencies: minimist, async, fast-json-stringify
Dschoordsch added a commit to ParabolInc/parabol that referenced this pull request Jun 22, 2023
Dschoordsch added a commit to ParabolInc/parabol that referenced this pull request Jun 22, 2023
Dschoordsch added a commit to ParabolInc/parabol that referenced this pull request Jun 23, 2023
* fix: canAccess field for Organization

* Enable typecheck for server/graphql/public/types

* Fix types in graphql/private/queries

* Add typesafe enum lookup function

A common use case is to have a lookup object with enum values as keys
and then looking up by enum. This oftentimes requires casting and can
lead to errors. Encapsulate the call in a function with some type
checking.

* Fix graphql/private/mutations type errors (except stripe)

* Fix stripe types in graphql/private/mutations

* Bump graphql-jit to fix @include @fix in mutations

zalando-incubator/graphql-jit#172 was fixed in
0.7.4

* Fix types in graphql/public/mutations

* Enable typecheck for server/grapqhl

* Fix merge

* Cleanup

* Prettier

* Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directives are ignored by mutations
3 participants