Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to configure max-pods and node-cidr-mask-size per cluster #2090

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
4 participants
@mikkeloscar
Copy link
Contributor

commented May 3, 2019

This enables us to change the configuration per cluster.

We want to change the configuration because the current settings limits us to 256 nodes when each node has a /24. Setting this to /25 would allow around ~510 nodes at the cost of limiting the number of pods per node to ~62.

Note I didn't pass the max-pods flag for the worker kubelet to prevent another rolling upgrade. Will add this to the v1.13 branch.

Make it possible to configure max-pods and node-cidr-mask-size per cl…
…uster

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
@arjunrn

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

👍

1 similar comment
@mikkeloscar

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

👍

@mikkeloscar mikkeloscar merged commit ccf1a3c into dev May 3, 2019

6 checks passed

DCO DCO
Details
pipeline Pipeline succeeded.
Details
process/stups-test/e2e-tests Process step succeeded.
Details
script/build Script step succeeded.
Details
zappr Approvals: @arjunrn, @mikkeloscar.
zappr/pr/specification PR has passed specification checks

@mikkeloscar mikkeloscar deleted the parameterize-max-pods branch May 3, 2019

This was referenced May 3, 2019

@hjacobs

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

Observed error message (for context):

Error while processing Node Add/Delete: failed to allocate cidr: CIDR allocation failed; there are no remaining CIDRs left to allocate in the accepted range'

Relevant controller code: https://github.com/kubernetes/kubernetes/blob/a89f8c11a5f4f132503edbc4918c98518fd504e3/pkg/controller/nodeipam/ipam/cidrset/cidr_set.go#L136-L156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.