Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix my user name in codeowners file #122

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@ePaul
Copy link
Member

commented Apr 16, 2019

The codeowners file used my username from our internal systems, not my github.com one, and thus didn't work.

Not sure how that happened, and was not noticed until now.

fix my user name in codeowners file
Not sure how that happened, and was not noticed until now.

@ePaul ePaul requested a review from BGehrels Apr 16, 2019

@ePaul

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

👍

1 similar comment
@BGehrels

This comment has been minimized.

Copy link
Collaborator

commented Apr 16, 2019

👍

@BGehrels BGehrels merged commit c924fec into master Apr 16, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr Approvals: @ePaul, @BGehrels.
zappr/pr/specification PR has passed specification checks

@BGehrels BGehrels deleted the fix-codeowners-user-name branch Apr 16, 2019

@BGehrels BGehrels referenced this pull request May 6, 2019

Merged

Backport features from v20 #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.