Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOM missing logbook-logstash for 2.0.0-RC.1 #502

Closed
binkley opened this issue May 15, 2019 · 1 comment · Fixed by #503
Closed

BOM missing logbook-logstash for 2.0.0-RC.1 #502

binkley opened this issue May 15, 2019 · 1 comment · Fixed by #503
Labels

Comments

@binkley
Copy link

binkley commented May 15, 2019

Description

When using the BOM in Gradle, the logbook-logstash dependency is not provided with a version number. Gradle did, however, resolve the version as "2.0.0-RC.1" for logbook-spring-boot-starter.

Expected Behavior

Using logbook-logstash dependency in Gradle with the BOM should not require an explicit version number.

Actual Behavior

I needed to specify the version number explicitly in build.gradle for logbook-logstash.

Possible Fix

Visual inspection confirms that pom.xml for logbook-bom does not mention logbook-logstash. The fix should be simple, and add logbook-logstash to that pom.xml.

Steps to Reproduce

In my Gradle (I expect a Maven pom.xml to work the same way):

ext {
    logbookVersion = "2.0.0-RC.1"
}

dependencyManagement {
    imports {
        mavenBom "org.zalando:logbook-bom:${logbookVersion}"
    }
}

dependencies {
    implementation "org.zalando:logbook-spring-boot-starter"

    // To reproduce, remove the version part:
    runtimeOnly "org.zalando:logbook-logstash:${logbookVersion}"
}

Your Environment

whiskeysierra added a commit that referenced this issue May 15, 2019
@whiskeysierra
Copy link
Collaborator

Thanks for raising this. I opened PR #503 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants