Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json tests aren't windows friendly #924

Closed
nhomble opened this issue Jan 6, 2021 · 0 comments
Closed

json tests aren't windows friendly #924

nhomble opened this issue Jan 6, 2021 · 0 comments
Labels
Bug

Comments

@nhomble
Copy link
Contributor

nhomble commented Jan 6, 2021

When testing pretty jsons, the string makes the assumption on line separators \n.

Description

If we aim to be windows friendly, just replace with System.lineSeparator()

Expected Behavior

Unit tests should pass

Actual Behavior

String comparison of pretty jsons differed on line separators

Possible Fix

System.lineSeparator()

Steps to Reproduce

  1. Ran PrettyPrintingJsonBodyFilterTest on my windows machine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whiskeysierra @nhomble