Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAruha 1173 #838
Conversation
antban
added some commits
Oct 4, 2017
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Feb 12, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
============================================
+ Coverage 53.18% 53.64% +0.46%
- Complexity 1639 1682 +43
============================================
Files 310 310
Lines 9206 9326 +120
Branches 806 837 +31
============================================
+ Hits 4896 5003 +107
- Misses 4021 4025 +4
- Partials 289 298 +9
Continue to review full report at Codecov.
|
| batch.add(new BatchItem(sb.toString())); | ||
| public static List<BatchItem> from(final String events) { | ||
| final List<BatchItem> batch = new ArrayList<>(); | ||
| int objectStart = locateOpenSquareBracket(events) + 1; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
antban
Feb 16, 2018
Member
@adyach not to parse too much, also, the name is perfectly correct. object start may be only openSquareBracket + 1 and further.
| import java.util.Optional; | ||
| public class BatchItem { | ||
| public enum Injection { | ||
| METADATA("metadata"),; |
This comment has been minimized.
This comment has been minimized.
| } | ||
| return idx; | ||
| } | ||
| } |
This comment has been minimized.
This comment has been minimized.
| event.put("metadata", sourceMetadata); | ||
| event.put("foo", "Test data data data"); | ||
| final BatchItem bi = BatchFactory.from("[" + event.toString(2) + "]").get(0); |
This comment has been minimized.
This comment has been minimized.
antban
added some commits
Feb 16, 2018
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
deploy validation please |
This comment has been minimized.
This comment has been minimized.
|
|
antban
added some commits
Feb 19, 2018
This comment has been minimized.
This comment has been minimized.
|
deploy validation please |
This comment has been minimized.
This comment has been minimized.
|
deploy validation please |
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
deploy validation please |
This comment has been minimized.
This comment has been minimized.
|
deploy validation please |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
deploy validation please |
This comment has been minimized.
This comment has been minimized.
|
|
antban
merged commit 934ac9f
into
master
Apr 5, 2018
7 of 8 checks passed
Codacy/PR Quality Review
Not so good... This pull request quality could be better.
Details
codecov/patch
86.84% of diff hit (target 53.18%)
Details
codecov/project
53.64% (+0.46%) compared to 34bb11f
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
default
Build finished.
Details
zappr
Approvals: @antban, @lmontrieux.
zappr/pr/specification
PR has passed specification checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
antban commentedFeb 12, 2018
•
edited
Do not reformat incoming messages while publishing
Description
Right now nakadi is parsing json while validating events and than stores events from parsed format to a kafka format. This may lead to problems user behavior (for example 0.0 and 0 should be treated in the same manner, but it is actually not)
This ticket prevents nakadi from this kind of modifications, removing only meaningless values from the events.