New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INC-13145 Do not log stack trace when users provide a non-existing subscription ID #857

Merged
merged 3 commits into from Apr 3, 2018

Conversation

4 participants
@lmontrieux
Member

lmontrieux commented Mar 29, 2018

Do not log stack trace when users provide a non-existing subscription ID

Zalando ticket : INC-13145

Description

This PR stops logging a full stack trace when a users makes a GET request to /subscriptions/{id} or /subscriptions/{id}/events with a subscription ID that does not exist

@codecov-io

This comment has been minimized.

codecov-io commented Mar 29, 2018

Codecov Report

Merging #857 into master will decrease coverage by 0.03%.
The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #857      +/-   ##
===========================================
- Coverage     53.23%   53.2%   -0.04%     
  Complexity     1640    1640              
===========================================
  Files           310     310              
  Lines          9200    9206       +6     
  Branches        805     806       +1     
===========================================
  Hits           4898    4898              
- Misses         4014    4020       +6     
  Partials        288     288
Impacted Files Coverage Δ Complexity Δ
...a/org/zalando/nakadi/service/BlacklistService.java 13.04% <0%> (-0.6%) 3 <0> (ø)
...akadi/controller/SubscriptionStreamController.java 12.9% <0%> (-0.44%) 2 <0> (ø)
...nakadi/repository/db/SubscriptionDbRepository.java 1.36% <0%> (ø) 1 <0> (ø) ⬇️
...kadi/service/subscription/SubscriptionService.java 82.39% <100%> (ø) 27 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be882e...f77257e. Read the comment docs.

@lmontrieux lmontrieux added the bug label Mar 29, 2018

@adyach

This comment has been minimized.

Member

adyach commented Mar 29, 2018

👍

1 similar comment
@lmontrieux

This comment has been minimized.

Member

lmontrieux commented Mar 29, 2018

👍

@lmontrieux

This comment has been minimized.

Member

lmontrieux commented Mar 29, 2018

Deploy validation please

lmontrieux added some commits Apr 3, 2018

@lmontrieux

This comment has been minimized.

Member

lmontrieux commented Apr 3, 2018

👍

1 similar comment
@rcillo

This comment has been minimized.

Member

rcillo commented Apr 3, 2018

👍

@lmontrieux lmontrieux merged commit 34bb11f into master Apr 3, 2018

4 of 7 checks passed

Codacy/PR Quality Review Not so good... This pull request quality could be better.
Details
codecov/patch 12.5% of diff hit (target 53.23%)
Details
codecov/project 53.2% (-0.04%) compared to 2be882e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr Approvals: @lmontrieux, @rcillo.
zappr/pr/specification PR has passed specification checks

@lmontrieux lmontrieux deleted the INC-13145 branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment