New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log stack trace when event type does not exist #859

Merged
merged 2 commits into from Apr 10, 2018

Conversation

3 participants
@lmontrieux
Member

lmontrieux commented Apr 10, 2018

Do not log stack trace when event type does not exist

Zalando ticket : ARUHA-1581

Description

Do not log stack trace when event type does not exist

Review

  • Tests
  • Documentation
  • CHANGELOG
@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## [Unreleased]
## [2.6.3] = 2018-04-10

This comment has been minimized.

@v-stepanov

v-stepanov Apr 10, 2018

Member

- instead of =

This comment has been minimized.

@lmontrieux
@v-stepanov

This comment has been minimized.

Member

v-stepanov commented Apr 10, 2018

👍

@lmontrieux

This comment has been minimized.

Member

lmontrieux commented Apr 10, 2018

Deploy validation please

@lmontrieux

This comment has been minimized.

Member

lmontrieux commented Apr 10, 2018

👍

@codecov-io

This comment has been minimized.

codecov-io commented Apr 10, 2018

Codecov Report

Merging #859 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #859   +/-   ##
=========================================
  Coverage     53.62%   53.62%           
  Complexity     1681     1681           
=========================================
  Files           310      310           
  Lines          9326     9326           
  Branches        837      837           
=========================================
  Hits           5001     5001           
- Misses         4026     4027    +1     
+ Partials        299      298    -1
Impacted Files Coverage Δ Complexity Δ
...do/nakadi/repository/db/EventTypeDbRepository.java 4.34% <0%> (ø) 1 <0> (ø) ⬇️
...o/nakadi/controller/EventPublishingController.java 85.5% <100%> (ø) 16 <0> (ø) ⬇️
...lando/nakadi/service/timeline/TimelineService.java 32.63% <50%> (ø) 16 <0> (ø) ⬇️
...g/zalando/nakadi/exceptions/NotFoundException.java 50% <0%> (-50%) 1% <0%> (-1%)
...n/java/org/zalando/nakadi/service/EventStream.java 75% <0%> (+1.61%) 30% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb54e61...1aaddd6. Read the comment docs.

@lmontrieux lmontrieux merged commit 431b282 into master Apr 10, 2018

5 of 8 checks passed

Codacy/PR Quality Review Not so good... This pull request quality could be better.
Details
codecov/patch 50% of diff hit (target 53.62%)
Details
default Build finished.
Details
codecov/project 53.62% remains the same compared to fb54e61
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr Approvals: @v-stepanov, @lmontrieux.
zappr/pr/specification PR has passed specification checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment