New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARUHA-1604: added flushing collected events when reaching stream timeout #860

Merged
merged 5 commits into from Apr 26, 2018

Conversation

5 participants
@v-stepanov
Member

v-stepanov commented Apr 12, 2018

Added flushing collected events when reaching stream timeout in subscription API

Zalando ticket : ARUHA-1604

Description

When stream_timeout is reached user wants to get events which were collected so far.

Review

  • Tests
  • Documentation
  • CHANGELOG

Deployment Notes

We should keep an eye on complaining users

@codecov-io

This comment has been minimized.

codecov-io commented Apr 12, 2018

Codecov Report

Merging #860 into master will increase coverage by 0.01%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #860      +/-   ##
============================================
+ Coverage     53.56%   53.57%   +0.01%     
- Complexity     1691     1694       +3     
============================================
  Files           309      309              
  Lines          9359     9366       +7     
  Branches        841      843       +2     
============================================
+ Hits           5013     5018       +5     
- Misses         4046     4049       +3     
+ Partials        300      299       -1
Impacted Files Coverage Δ Complexity Δ
...adi/service/subscription/state/StreamingState.java 35.09% <0%> (-0.28%) 35 <0> (ø)
...kadi/service/subscription/state/PartitionData.java 78.57% <100%> (+2.32%) 23 <0> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f9610...53a25fe. Read the comment docs.

@antban

This comment has been minimized.

Member

antban commented Apr 13, 2018

👍

@v-stepanov

This comment has been minimized.

Member

v-stepanov commented Apr 13, 2018

deploy validation please

3 similar comments
@v-stepanov

This comment has been minimized.

Member

v-stepanov commented Apr 16, 2018

deploy validation please

@adyach

This comment has been minimized.

Member

adyach commented Apr 16, 2018

deploy validation please

@adyach

This comment has been minimized.

Member

adyach commented Apr 16, 2018

deploy validation please

@@ -101,6 +101,23 @@ public void whenStreamTimeoutReachedPossibleToCommit() throws Exception {
Assert.assertEquals(SC_NO_CONTENT, statusCode);
}
@Test(timeout = 10000)
public void whenStreamTimeoutReachedThenEventsFlushed() throws Exception {

This comment has been minimized.

@rcillo

rcillo Apr 24, 2018

Member

I tested streaming using this same parameter in the old stack and the new one and both behave the same way. Both got 2 batches, one containing 3 events and the other with debug message. Does this test actually exercise or prove that the fix works?

This comment has been minimized.

@v-stepanov

v-stepanov Apr 24, 2018

Member

I remember that I was running this test against the old version and it failed. I will check it again now.

This comment has been minimized.

@v-stepanov

v-stepanov Apr 24, 2018

Member

Oh yes, sorry, I remembered now. I changed the test later and it actually now works for old version as well (as it reaches max_uncommitted_events)
I now changed the test. It will now fail in old version and will work for new version.

This comment has been minimized.

@v-stepanov
@rcillo

This comment has been minimized.

Member

rcillo commented Apr 25, 2018

👍

Merge remote-tracking branch 'origin/master' into ARUHA-1604-flush-on…
…-stream-timeout

# Conflicts:
#	CHANGELOG.md
@antban

This comment has been minimized.

Member

antban commented Apr 26, 2018

👍

1 similar comment
@v-stepanov

This comment has been minimized.

Member

v-stepanov commented Apr 26, 2018

👍

@v-stepanov v-stepanov merged commit 87bf767 into master Apr 26, 2018

5 of 7 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
codecov/patch 40% of diff hit (target 53.56%)
Details
codecov/project 53.57% (+0.01%) compared to 46f9610
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr Approvals: @antban, @v-stepanov.
zappr/pr/specification PR has passed specification checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment