/nakadi

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aruha 1624 out of memory #864

Merged
merged 3 commits into from Apr 25, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@v-stepanov @codecov-io @rcillo
@v-stepanov
Member

v-stepanov commented Apr 23, 2018 •
edited

Fixed out of memory problem

OutOfMemoryError in case of using very large max_uncommitted_events and batch_limit : ARUHA-1624

Description

Fixed OutOfMemoryError when using huge values for batch_limit and max_uncommitted_events

Review

  • Tests
  • Documentation
  • CHANGELOG

Deployment Notes
@codecov-io

This comment has been minimized.

Sign in to view

codecov-io commented Apr 23, 2018 •
edited

Codecov Report

Merging #864 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #864   +/-   ##
=========================================
  Coverage     53.56%   53.56%           
  Complexity     1691     1691           
=========================================
  Files           309      309           
  Lines          9359     9359           
  Branches        841      841           
=========================================
  Hits           5013     5013           
  Misses         4046     4046           
  Partials        300      300
Impacted Files Coverage Δ Complexity Δ
...kadi/service/subscription/state/PartitionData.java 76.25% <100%> (ø) 20 <4> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f56de8a...9a90b69. Read the comment docs.
@rcillo

This comment has been minimized.

Sign in to view
Member

rcillo commented Apr 23, 2018

👍
1 similar comment
@v-stepanov

This comment has been minimized.

Sign in to view
Member

v-stepanov commented Apr 23, 2018

👍
@v-stepanov

This comment has been minimized.

Sign in to view
Member

v-stepanov commented Apr 23, 2018

deploy validation please
@v-stepanov
Merge remote-tracking branch 'origin/master' into ARUHA-1624-out-of-m… 
…emory

# Conflicts:
#	CHANGELOG.md
Loading status checks…
9a90b69
@v-stepanov

This comment has been minimized.

Sign in to view
Member

v-stepanov commented Apr 25, 2018

👍
1 similar comment
@rcillo

This comment has been minimized.

Sign in to view
Member

rcillo commented Apr 25, 2018

👍

@v-stepanov v-stepanov merged commit 46f9610 into master Apr 25, 2018
7 checks passed

7 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 53.56%)
Details
codecov/project 53.56% (+0%) compared to f56de8a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr Approvals: @v-stepanov, @rcillo.
zappr/pr/specification PR has passed specification checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment