New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARUHA-1640: improve light stats performance; #869

Merged
merged 7 commits into from May 15, 2018

Conversation

4 participants
@v-stepanov
Member

v-stepanov commented May 3, 2018

Take partition list from ZK if possible

Zalando ticket : ARUHA-1640

Description

Now the list of partitions is taken from ZK node if it is present

Review

  • Tests
  • Documentation
  • CHANGELOG

Deployment Notes

@v-stepanov

This comment has been minimized.

Member

v-stepanov commented May 3, 2018

deploy validation please

@codecov-io

This comment has been minimized.

codecov-io commented May 3, 2018

Codecov Report

Merging #869 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #869      +/-   ##
============================================
- Coverage     53.42%   53.37%   -0.05%     
+ Complexity     1695     1694       -1     
============================================
  Files           310      310              
  Lines          9398     9403       +5     
  Branches        845      845              
============================================
- Hits           5021     5019       -2     
- Misses         4077     4083       +6     
- Partials        300      301       +1
Impacted Files Coverage Δ Complexity Δ
...kadi/service/subscription/SubscriptionService.java 74.56% <0%> (-2.22%) 37 <0> (ø)
...n/java/org/zalando/nakadi/service/EventStream.java 73.38% <0%> (-1.62%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7611426...ee342bd. Read the comment docs.

@v-stepanov

This comment has been minimized.

Member

v-stepanov commented May 3, 2018

deploy validation please

3 similar comments
@v-stepanov

This comment has been minimized.

Member

v-stepanov commented May 4, 2018

deploy validation please

@adyach

This comment has been minimized.

Member

adyach commented May 4, 2018

deploy validation please

@adyach

This comment has been minimized.

Member

adyach commented May 4, 2018

deploy validation please

@v-stepanov v-stepanov changed the title from ARUHA-1640: added time logging for light stats; to ARUHA-1640: improve light stats performance; May 4, 2018

@rcillo

This comment has been minimized.

Member

rcillo commented May 7, 2018

👍

1 similar comment
@v-stepanov

This comment has been minimized.

Member

v-stepanov commented May 7, 2018

👍

@rcillo

This comment has been minimized.

Member

rcillo commented May 15, 2018

👍

1 similar comment
@v-stepanov

This comment has been minimized.

Member

v-stepanov commented May 15, 2018

👍

@v-stepanov v-stepanov merged commit 81bd9f9 into master May 15, 2018

5 of 7 checks passed

codecov/patch 0% of diff hit (target 53.42%)
Details
codecov/project 53.37% (-0.05%) compared to 7611426
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr Approvals: @rcillo, @v-stepanov.
zappr/pr/specification PR has passed specification checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment