/nakadi

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aruha-1636: unlimited retention time by Nakadi admin #871

Merged
merged 3 commits into from May 8, 2018

Conversation

Reviewers

@rcillo rcillo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@adyach @codecov-io @rcillo
@adyach
Member

adyach commented May 4, 2018

One-line summary

Zalando ticket : aruha-1636 (only if appropriate)

Description

Allow Nakadi admin set unlimited retention time

adyach added some commits May 4, 2018

@adyach
aruha-1636: unlimited retention time by Nakadi admin
Verified
This commit was signed with a verified signature.
@adyach adyach Andrey Dyachkov
GPG key ID: 7A053D1159DA88AF Learn about signing commits
Loading status checks…
10a19da
@adyach
aruha-1636: fixed checkstyle
Verified
This commit was signed with a verified signature.
@adyach adyach Andrey Dyachkov
GPG key ID: 7A053D1159DA88AF Learn about signing commits
Loading status checks…
9a89c55
@codecov-io

This comment has been minimized.

Sign in to view

codecov-io commented May 4, 2018 •
edited

Codecov Report

Merging #871 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #871   +/-   ##
=========================================
  Coverage     53.42%   53.42%           
  Complexity     1695     1695           
=========================================
  Files           309      310    +1     
  Lines          9398     9398           
  Branches        845      845           
=========================================
  Hits           5021     5021           
  Misses         4077     4077           
  Partials        300      300
Impacted Files Coverage Δ Complexity Δ
...ava/org/zalando/nakadi/config/ValidatorConfig.java 100% <ø> (ø) 3 <0> (ø) ⬇️
.../java/org/zalando/nakadi/service/AdminService.java 54.16% <ø> (ø) 15 <0> (ø) ⬇️
...zalando/nakadi/controller/EventTypeController.java 85.96% <100%> (-0.25%) 22 <1> (+1)
.../service/validation/EventTypeOptionsValidator.java 100% <100%> (ø) 6 <6> (?)
...s/runtime/EventTypeOptionsValidationException.java 100% <100%> (ø) 1 <1> (?)
...a/org/zalando/nakadi/service/EventTypeService.java 76.92% <100%> (+0.5%) 45 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1446829...1282961. Read the comment docs.
src/test/java/org/zalando/nakadi/validation/EventTypeOptionsValidatorTest.java Outdated
Mockito.verify(mockedErrors, Mockito.times(0)).rejectValue(Matchers.any(), Matchers.any(),
Matchers.any());
validator.checkRetentionTime(eventTypeOptions);

This comment has been minimized.

Sign in to view
Copy link
@rcillo

rcillo May 4, 2018

Member

What is this test testing? Maybe just remove it completely?

This comment has been minimized.

Sign in to view
Copy link
@adyach

adyach May 4, 2018

Member

1282961
@adyach
aruha-1636: removed test
Verified
This commit was signed with a verified signature.
@adyach adyach Andrey Dyachkov
GPG key ID: 7A053D1159DA88AF Learn about signing commits
Loading status checks…
1282961
@rcillo

This comment has been minimized.

Sign in to view
Member

rcillo commented May 4, 2018

👍
@adyach

This comment has been minimized.

Sign in to view
Member

adyach commented May 4, 2018

deploy validation please
2 similar comments
@adyach

This comment has been minimized.

Sign in to view
Member

adyach commented May 4, 2018

deploy validation please
@adyach

This comment has been minimized.

Sign in to view
Member

adyach commented May 4, 2018

deploy validation please
@adyach

This comment has been minimized.

Sign in to view
Member

adyach commented May 8, 2018

👍

@adyach adyach merged commit 6d4849e into master May 8, 2018
8 checks passed

8 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 53.42%)
Details
codecov/project 53.42% (+0%) compared to 1446829
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
default Build finished.
Details
zappr Approvals: @rcillo, @adyach.
zappr/pr/specification PR has passed specification checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment