aruha-1636: unlimited retention time by Nakadi admin #871
Conversation
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
=========================================
Coverage 53.42% 53.42%
Complexity 1695 1695
=========================================
Files 309 310 +1
Lines 9398 9398
Branches 845 845
=========================================
Hits 5021 5021
Misses 4077 4077
Partials 300 300
Continue to review full report at Codecov.
|
|
|
||
| Mockito.verify(mockedErrors, Mockito.times(0)).rejectValue(Matchers.any(), Matchers.any(), | ||
| Matchers.any()); | ||
| validator.checkRetentionTime(eventTypeOptions); |
rcillo
May 4, 2018
Contributor
What is this test testing? Maybe just remove it completely?
What is this test testing? Maybe just remove it completely?
|
|
|
deploy validation please |
2 similar comments
|
deploy validation please |
|
deploy validation please |
|
|
adyach
merged commit 6d4849e
into
master
8 checks passed
8 checks passed
zappr
Approvals: @rcillo, @adyach.
zappr/pr/specification
PR has passed specification checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
One-line summary
Description
Allow Nakadi admin set unlimited retention time