New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARUHA-1674 use gzip compression on post requests as well #880

Merged
merged 1 commit into from May 28, 2018

Conversation

4 participants
@antban
Member

antban commented May 24, 2018

ARUHA-1674
As there are requests that are "GET with POST" we have to support gzip compression on post requests as well

@v-stepanov

This comment has been minimized.

Member

v-stepanov commented May 24, 2018

👍

@codecov-io

This comment has been minimized.

codecov-io commented May 24, 2018

Codecov Report

Merging #880 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #880      +/-   ##
============================================
- Coverage     53.39%   53.38%   -0.02%     
+ Complexity     1695     1694       -1     
============================================
  Files           310      310              
  Lines          9403     9404       +1     
  Branches        845      845              
============================================
- Hits           5021     5020       -1     
- Misses         4082     4083       +1     
- Partials        300      301       +1
Impacted Files Coverage Δ Complexity Δ
...in/java/org/zalando/nakadi/config/JettyConfig.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...n/java/org/zalando/nakadi/service/EventStream.java 73.38% <0%> (-1.62%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81bd9f9...79876ba. Read the comment docs.

@antban

This comment has been minimized.

Member

antban commented May 24, 2018

👍

@antban

This comment has been minimized.

Member

antban commented May 24, 2018

deploy validation please

1 similar comment
@adyach

This comment has been minimized.

Member

adyach commented May 25, 2018

deploy validation please

@antban antban merged commit 0ab33e1 into master May 28, 2018

8 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
aruha/jenkins Build finished.
Details
codecov/patch 100% of diff hit (target 53.39%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +46.6% compared to 81bd9f9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr Approvals: @v-stepanov, @antban.
zappr/pr/specification PR has passed specification checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment